Ticket #10224: dynamic-casts-error-checking.patch

src/apps/debugger/arch/x86/ArchitectureX86.cpp

@@ -272 +272 @@
     CpuState*& _previousCpuState)
 {
     CpuStateX86* cpuState = dynamic_cast<CpuStateX86*>(_cpuState);
-
+    if (!cpuState) {
+        fprintf(stderr, "ArchitectureX86::CreateStackFrame(): \
+                            Dynamic Cast failed");
+        return B_ERROR;
+    }
+    
     uint32 framePointer = cpuState->IntRegisterValue(X86_REGISTER_EBP);
     uint32 eip = cpuState->IntRegisterValue(X86_REGISTER_EIP);
 
@@ -416 +421 @@
     // This is not a top frame, so we want to offset eip to the previous
     // (calling) instruction.
     CpuStateX86* cpuState = dynamic_cast<CpuStateX86*>(previousCpuState);
+    if (!cpuState)
+        debugger("ArchitectureX86::CreateStackFrame(): \
+                            Dynamic Cast failed");
 
     // get eip
     uint32 eip = cpuState->IntRegisterValue(X86_REGISTER_EIP);
@@ -676 +684 @@
     } else {
         ValuePieceLocation piece;
         CpuStateX86* state = dynamic_cast<CpuStateX86*>(frame->GetCpuState());
+        if (!state) {
+            fprintf(stderr, "ArchitectureX86::GetReturnAddressLocation(): \
+                                Dynamic Cast failed");
+            return B_ERROR;
+        }
+        
         piece.SetToMemory(state->IntRegisterValue(X86_REGISTER_EAX));
         piece.SetSize(valueSize);
         if (!location->AddPiece(piece))

src/apps/debugger/user_interface/gui/util/SettingsMenu.cpp

@@ -16 +16 @@
 #include "MessageCodes.h"
 #include "SettingsDescription.h"
 
-
 // #pragma mark - SettingsMenu
 
 
@@ -176 +175 @@
     {
         SettingsOption* selectedOption = settings->OptionValue(
             dynamic_cast<OptionsSetting*>(GetSetting()));
+        if (!selectedOption)
+            debugger("SettingsMenuImpl::PrepareToShow(): \
+                                Dynamic cast failed");  
 
         for (int32 i = 0; BMenuItem* item = Submenu()->ItemAt(i); i++) {
             OptionMenuItem* optionItem = dynamic_cast<OptionMenuItem*>(item);

src/apps/debugger/value/value_nodes/ArrayValueNode.cpp

@@ -315 +315 @@
 
         child = dynamic_cast<AbstractArrayValueNodeChild*>(
             child->ArrayParent()->NodeChild());
+        if (!child) {
+            fprintf(stderr, "ArrayValueNodeChild::ResolveLocation(): \
+                                Dynamic cast failed");  
+            return B_ERROR;
+        }
     }
 
     // resolve the element location

src/apps/debugger/value/value_nodes/BMessageValueNode.cpp

@@ -70 +70 @@
         ValueLocation* parentLocation = fParent->Location();
         ValueLocation* location;
         CompoundType* type = dynamic_cast<CompoundType*>(fParent->GetType());
+        if (!type)
+            debugger("Dynamic cast failed");    
+        
         status_t error = B_OK;
         if (fParent->fIsFlatMessage) {
             location = new ValueLocation();
@@ -334 +337 @@
 {
     DataMember* member = NULL;
     CompoundType* messageType = dynamic_cast<CompoundType*>(fType);
+    if (!messageType) {
+        fprintf(stderr, "BMessageValueNode::CreateChildren(): \
+                            Dynamic cast failed");
+        return B_ERROR;
+    }
+    
     for (int32 i = 0; i < messageType->CountDataMembers(); i++) {
         member = messageType->DataMemberAt(i);
         if (strcmp(member->Name(), "what") == 0) {