Changeset 24196

Timestamp:

03/01/08 19:06:45 (9 months ago)

Author:

julun

Message:

* This fixes ticket #1865
* Allocate the buffer to flatten the message on the heap, if it's size is bigger then a given

buffer on the stack. It seem's to exceed the stack size (this might count for AddFlat() too).

Note: With this change one is able to copy the text into the clipboard (1mb), but it

is still impossible to paste it somewhere, as in BClipboard::_DownloadFromSystem()
SendMessage() fails transferring the data back in the reply msg because of the port size limit...

Files:

• haiku/trunk/src/kits/app/Message.cpp (modified) (1 diff)

haiku/trunk/src/kits/app/Message.cpp

@@ -2301 +2301 @@
         pointer into the message. */
 
+        char buf[4096] = { 0 };
         ssize_t size = message->FlattenedSize();
-        char buffer[size];
+
+        bool freeBuffer = false;
+        char* buffer = NULL;
+        if (size > (ssize_t)sizeof(buffer)) {
+                freeBuffer = true;
+                buffer = static_cast<char*>(malloc(size));
+        } else {
+                buffer = buf;
+        }
 
         status_t error = message->Flatten(buffer, size);
 
         if (error >= B_OK)
-                error = AddData(name, B_MESSAGE_TYPE, &buffer, size, false);
+                error = AddData(name, B_MESSAGE_TYPE, buffer, size, false);
+
+        if (freeBuffer)
+                free(buffer);
 
         return error;