Changeset 25478

Timestamp:

05/12/08 16:48:03 (6 months ago)

Author:

bonefish

Message:

* unsetenv() was moving too much memory, thus corrupting the data after

its allocation.

* Added TODO to use a benaphore.

Files:

• haiku/trunk/src/system/libroot/posix/stdlib/env.c (modified) (2 diffs)

haiku/trunk/src/system/libroot/posix/stdlib/env.c

@@ -24 +24 @@
 
 
+// TODO: Use benaphore!
 static sem_id sEnvLock;
 static bool sCopied;
@@ -213 +214 @@
         env = find_variable(name, length, &index);
         if (env != NULL) {
-                // we don't free the memory for the slot, we just move the array contents
+                // we don't free the memory for the slot, we just move the array
+                // contents
                 free(env);
-                memmove(environ + index, environ + index + 1, sizeof(char *) * (count_variables() + 1));
+                memmove(environ + index, environ + index + 1,
+                        sizeof(char *) * (count_variables() - index));
         }