inconsistent behavior of Revert button in Backgrounds preflet (easy)

[wkornewald]

Open the Backgrounds preflet, change something, click Apply. Result: you can't click on Revert, anymore.

Revert should bring all workspaces back to the state when the application was started.

[korli]

* Revert lets you go back to the current workspace settings (even after having applied), and it's the good behavior. * I don't understand the second point.

[wkornewald]

Replying to korli:

* Revert lets you go back to the current workspace settings (even after having applied), and it's the good behavior.

In order to analyze the problem, I've been playing with the Screen preflet which has the same behavior and I agree that for preflets which have an Apply button Revert should go back to the currently active configuration. What irritated me was that right after having clicked Apply I didn't get a chance to revert to the configuration before I pressed Apply. I don't see why this should be prohibited.

If you make new changes after having clicked Apply the Revert button should only undo the new changes (like it already does).

BTW, R5 has similar behavior for Screen (only Backgrounds is an exception): Revert always brings you back to the state at program start (even after having pressed Apply). I've tested this scheme, too, but I think that the suggestion above is more intuitive. In case you want to test that behavior, I've committed my modified version of Screen (it can still be reverted).

At least, in R5 Backgrounds is not consistent with the other preflets, so I think we should fix that behavior. What do you think?

* I don't understand the second point.

This is related to my suggestion above, but after having played around with the Screen preflet I think the second point is unnecessary and it's not worth the effort.

[wkornewald]

Revert should bring all workspaces back to the state when the application was started because that is more consistent with the behavior of all other preflets.

[max luebbe]

Replying to korli:

* Revert lets you go back to the current workspace settings (even after having applied), and it's the good behavior. * I don't understand the second point.

I'm having trouble deducing what is the desired behavior from the comments here. This should be easy to fix with some clarification.

Example: Background is solid green when I open the app. I then change the sliders to blue and hit apply. I then change the sliders to gray.

At this point if I click Revert is the correct behavior:

a) Changing the background and sliders back to solid green b) changing the background to solid green keeping the sliders at current setting c) changing the sliders to blue, keeping the current background of blue d) something else

[wkornewald]

Replying to max luebbe:

I'm having trouble deducing what is the desired behavior from the comments here. This should be easy to fix with some clarification. Example: Background is solid green when I open the app. I then change the sliders to blue and hit apply. I then change the sliders to gray. At this point if I click Revert is the correct behavior: a) Changing the background and sliders back to solid green b) changing the background to solid green keeping the sliders at current setting c) changing the sliders to blue, keeping the current background of blue d) something else

Let me clarify just in case you're still interested in fixing this: It should be (a) because all other preflets behave like that. Maybe you should ask on the mailing list before implementing it, though (I'm not part of the team, anymore, so my suggestion might not be accepted).

Well, an even better solution would be to have undo/redo where you can go through each change step-by-step, but that would have to be done for all preflets to not break consistency. Maybe with a reusable settings+history framework this could be implemented everywhere without a lot of effort.

[add]

installing metal stair rails Interior stair handrail exterior baluster Glass wood stainless wrought CONTEMPORARY designs stairways aluminum modern log banister DECK outdoor price posts vinyl curved rails