Ticket #1391 (closed bug: fixed)

Opened 13 months ago

Last modified 11 days ago

[Tracker] don't show icons for volumes in mount menu (easy)

Reported by: diver Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1 development
Cc: Blocked By:
Platform: All Blocking:

Description

Mount menu doesn't show volume icon, only volume label.

Attachments

Ticket 1391 - Volume Mount Icons.diff (0.9 kB) - added by anxiety 3 weeks ago.
Mostly implimented already but commented out.

Change History

  Changed 6 months ago by diver

  • summary changed from [Tracker] no volume icon in mount menu to [Tracker] don't show icons for volumes in mount menu

  Changed 7 weeks ago by diver

  • summary changed from [Tracker] don't show icons for volumes in mount menu to [Tracker] don't show icons for volumes in mount menu (easy)

Changed 3 weeks ago by anxiety

Mostly implimented already but commented out.

in reply to: ↑ description   Changed 3 weeks ago by anxiety

I've tested it a couple times, the patch I supplied doesn't seem to have any problems that I'm aware of.

  Changed 2 weeks ago by diver

Could someone take a look at this patch?

  Changed 13 days ago by axeld

The patch looks good - the problem of this code is just that we currently have no way for a device to get a new style icon, and no icon looks better than the wrong one, IMO.

I'll see what I can do about changing this, and then we can apply this patch, too.

  Changed 11 days ago by axeld

  • status changed from new to closed
  • resolution set to fixed

Thanks for the patch, I've applied it (among other stuff) in r27001.

Note: See TracTickets for help on using tickets.