__STDC_NO_THREADS__ is not defined in Haiku

[Begasus]

When trying to build scipy I getting an error that the script wants to include "threads.h". This however isn't availabe in Haiku and the check for that is due to __STDC_NO_THREADS__ not being defined.

The source of the issue is with numpy. See a PR at ​https://github.com/numpy/numpy/pull/18180

__STDC_VERSION__ = 201710
__STDC_NO_THREADS__ not defined
__GLIBC__ not defined

[korli]

__STDC_NO_THREADS__ is theorically set by the compiler, based on its knowledge of the C library. Practically gcc seems to include the header stdc-prereqs.h, which would eventually define such a macro.

[Begasus]

Yeah, came across that also earlier, looked for that header but we don't include it in Haiku atm

[korli]

I added a stdc-prereqs.h with ​https://review.haiku-os.org/c/haiku/+/4097 When it's accepted, GCC and Clang can be adjusted.

[Begasus]

This has been accepted, I should check if it has been resolved, but I'm not sure if it also applied to R1B2?

[pulkomandy]

It has been applied to nightlies, but not to the stable beta2 branch.

[Begasus]

I think this could be closed, header is included in R1B3, building scipy without the patch for numpy seems to work (checked on x86_gcc2)

[Begasus]

Ok, no problem reported by numpy, but scipy still fails to find it, so I'm guessing that clang/gcc aren't adjusted to use it, so best to leave it open until then

[begasus]

Ran a check with the script mentioned at the issue at numpy, seems __STDC_NO_THREADS__ is still not defined, maybe we could use a simular work-around like OpenBSD?

​https://github.com/numpy/numpy/commit/5ffe257a19c5125ad981a5de018e5d492797d2e4

EDIT created a upstream PR until this is settled on Haiku side: ​https://github.com/numpy/numpy/pull/22272

[waddlesplash]

We don't define __STDC_NO_THREADS__ because we do actually support STDC threads now.

[begasus]

Replying to waddlesplash:

We don't define __STDC_NO_THREADS__ because we do actually support STDC threads now.

Building scipy without patching still errors out, this is one of the errors I encountered:

build/src.haiku-1-BePC-3.8/scipy/integrate/vodemodule.c:98:32: error: unknown type name 'thread_local

[waddlesplash]

Are you using GCC8? You can't use gcc2 for the new-style thread-local storage.

[begasus]

scipy is using secondary architecture, so yes using gcc11 for it

[korli]

Support for C11 thread isn't complete: only the Threads section is implemented.

[korli]

proposed the missing support in ​https://review.haiku-os.org/c/haiku/+/5675

[korli]

Merged in hrev56459

[begasus]

Build for numpy without patching works to get scipy build now, thanks korli!

[korli]

Thanks for the feedback, begasus.