Wrongly enabled buttons in apps/prefs (easy)

[diver]

There are several apps/prefs which enable some buttons on the first start, when i didn't change anything. Here is this list:

Fonts - Default
Keyboard - Default
Keymap - Revert, Use
Mouse - Default
Scroll Bar - Default
Virtual memory - Default

Also, when you start Sounds, you could see how butons becomes disabled Sounds - Play, Stop.

[wkornewald]

Screen should work correctly after my changes.

[anxiety]

Diff file

[anxiety]

I've attached a diff file that fixes the behavior of the default buttons, and hopefully handles the sounds issue satisfactory.

I did not make any changes to Keymap as the revert button doesn't do anything at all (with a note saying the original did not do anything either.) Perhaps that would be a good candidate for its own ticket?

[anxiety]

Diff file, sounds disables correctly in this one

[axeld]

Indeed, I think Keymap deserves its own ticket. Thanks!

[axeld]

And since ScrollBar has been removed, I'm closing this ticket now. Fixed in r21992.

[diver]

Oh yeah, E-mail pref app still need to be fixed, it was not in the image a year ago, so it didn't made up in this list in the first place.

[diver]

Also add to this list: Menu Screen Tracker Preferences

[diver]

Oops, i forgot about Appearance... So it must be

Appearance E-mail Menu Screen Tracker Preferences

[anxiety]

Diff file, contains changes for Appearance, Menu, and Tracker

[anxiety]

I was able to get Appearance, Menu and Tracker working. Screen seems to work fine as long as the screen isn't in VESA mode. When in VESA there seems to be something going on with the refresh rate, but I wasn't able to figure out what. Email is going to take me some time as its more complex.

After looking at tracker, I think the majority of pref apps could benefit from using a consistent settings setup like tracker has.

[axeld]

Thanks! In case you didn't notice, your patch was applied in r22049.

[diver]

I found some problems: Menu: Selecting "Ctrl as Shortcut key" and back doesn't disable Revert button.

Tracker preferences: Selecting "Show Volumes on Desktop" (which is default) enables Default button. This could be seen only once, to reproduce you have to reboot.

And Background have Revert and Apply enabled.

[aldeck]

Menu preflet should behave correctly with this.

[aldeck]

I hope that my patch is ok, i could have gone further in encapsulating all menu_info calls in the MenuSettings class and factoring/cleaning here and there, but i didn't want to make too much changes in one shot.

Going on to check the Screen preflet revert button, which should be disabled on start.

[stippi]

Works great, thanks a lot! Menu patch applied in r23296.

[aldeck]

Replying to stippi:

Works great, thanks a lot! Menu patch applied in r23296.

You're welcome! Thanks for the quick code review :)

[aldeck]

Corrects a little mistake in menu/ColorWindow.cpp

[aldeck]

menu2.diff applied in r23708

[diver]

There is still a problem with Tracker preferences.

[aldeck]

Replying to diver:

There is still a problem with Tracker preferences.

Didn't have much time these days. I just found the problem for Tracker settings. Will commit soon :-) Screen and Keymap still need some work though.

[aldeck]

Tracker settings Revert/Default buttons should now behave corectly with r24008. Note that Mount Settings can't be defaulted/reverted though, since it's handled quite differently.

[aldeck]

Keymap is fixed now! r24180

[aldeck]

Screen should be fixed! r24280

[diver]

There are still problems with Background.

[diver]

This bug could be closed as Background problems are documented in bug #1006

[aldeck]

Ok! Thanks for testing :)