[patch] DriveSetup doesn't use validated name when initialising volume

[idefix]

When you have a illegal volume name like installer/test, it gets validated to installer-test.
But when DriveSetup initialises the volume, it doesn't use the validated name, but the pre-validated one:

Attached patch​ fixes this behaviour.

[idefix]

DriveSetup window showing error when trying to initialise volume with illegal volume name

[idefix]

Patch to fix DriveSetups handling of illegal volume names

[diver]

While you at it there is an extra space in the alert string:

Initialization of the partition__"test" failed.

[idefix]

I just noticed a double space in the error dialog text, which this patch​ will fix.

[idefix]

Patch to fix double space in error dialog of DriveSetup

[idefix]

Replying to diver:

While you at it there is an extra space in the alert string:

Initialization of the partition__"test" failed.

Yeah, I noticed that too. :)

[diver]

unnamed partition

[stippi]

Thanks for the patches, will apply them.

[diver]

Stippi, should I open another bug described in the last two screenshots?

[stippi]

No, it's ok to keep it in this ticket I guess. Do you mean the problem is that DriveSetup should force you to enter a name? (I think it should.)

[idefix]

Or it could assign a default name like Unnamed; that's how mkfs does it.

[idefix]

BTW: I have another patch coming to fix DriveSetups handling of a volume name with a space in it. I was thinking of opening another ticket for this patch, but I could also attach it to this one if you keep it open for the bug described by diver.

[stippi]

Actually, Bryce could maybe also handle this, since he is working on DriveSetup anyway.

[idefix]

Well, this patch​ will fix the volume-name-contains-spaces-bug.

[idefix]

Path to allow DriveSetup initialise a BFS volume with a volume name that contains spaces

[idefix]

Replying to idefix:

Or it could assign a default name like Unnamed; that's how mkfs does it.

This patch​ makes DriveSetup do it the same way.

[idefix]

Patch to prevent DriveSetup create volumes without a name

[stippi]

To be honest, I think an alert requesting the user to enter a name may be a better solution. I think Bryce is even working on this already, but he is not on the Trac notification list, IIRC.

[idefix]

If you go that way, I would suggest to disable the Initialize button when the Name field is empty (see first screenshot​).
The user is already shown quite a lot of alerts when initialising a volume.

[stippi]

Ah yes, I think that's indeed the conclusion that Ingo and Bryce arrived at as well, IIRC. Sounds good to me. Still, I believe Bryce is already working on that one.

[idefix]

Well, we'll see what he comes up with then... :)

[stippi]

Is this still valid? IIRC, a fix was part of one of the patches from Bryce.

[idefix]

I just tried to initialise a volume with an empty name using a R1Alpha1 candidate image (hrev32917) and it succeeded.

[mmadia]

Thanks for the feedback idefix!

[idefix]

I've probably worded comment:17 not clear enough, but I shouldn't have succeeded in initialising a volume with an empty name. So the issue that diver mentioned in comment:5 isn't fixed yet (well, as of hrev32917; haven't tried it with a recent version).

I will try to create a patch for this in the coming weeks if Bryce has't done so already.

[idefix]

With drivesetupdisablebutton.patch​, DriveSetup will disable the Initialize button when the Name field is empty. It works correctly, but I'm not entirely happy with the implementation I've chosen (it isn't immediately clear where the MSG_NAME_CHANGED message comes from.)

Suggestions for improvement are more than welcome!

[idefix]

Patch to prevent DriveSetup initialise volumes without a name by disabling the Initialize button

[idefix]

Updated patch to prevent DriveSetup initialise volumes without a name by disabling the Initialize button (updated to account for the recent changes in DriveSetup)

[axeld]

Applied the patch in hrev35524, and added some minor TODOs. Can this ticket be fixed now, or are there other show stoppers?

[idefix]

Thanks!

This was the last thing to be fixed, so this ticket can be closed now.

[axeld]

Thanks for the fast response!