Improve layout of dialogs

[humdinger]

This is hrev32931.

The dialogs of DriveSetup could be visually improved. See attached shots.

Create:

• There's no need for the bordered box around the items.
• After Partition Size/Name/Type should be a colon.
• Remove Partition Name if it's not settable. Or align the textboxes of Name and Type if it's to be implemented.

Initialize:

• After Name/Blocksize should be a colon.
• The window shouldn't be resizable.
• There's too much vertical grey space above the first item.

[humdinger]

Create dialog

[humdinger]

Initialize dialog

[julun]

Fixed in 35120.

[humdinger]

Thanks julun! If I may nitpick: In the "Initialize" dialog the offset of the controls to the window borders and each other is a bit large compared with e.g. the "Create" dialog. Should you change that, could you add a ":" to "Name" and "Blocksize"?

[julun]

Replying to humdinger:

Thanks julun! If I may nitpick: In the "Initialize" dialog the offset of the controls to the window borders and each other is a bit large compared with e.g. the "Create" dialog. Should you change that, could you add a ":" to "Name" and "Blocksize"?

Hi, looking at my patch I thought I had changed that. See for example the first few lines in hrev35120. Also the spacing should be the same in both dialogs since I get it from be_control_look. Are you talking about a different dialog then the two above mentioned?

[humdinger]

Strangeness. I see the changes in the "Create" dialog (+":", -box), but the "Initialize" dialog is unchanged. Still talking about the same dialogs...
I just freshly jam -qa to hrev35141.

in the Create-dialog should be "Active partition".

[julun]

Hi, all outstanding issues should be fixed in hrev35144.

[humdinger]

Confirmed. Thanks!