[LaunchBox] "Set description" window appears offscreen

[diver]

Tested with hrev35600 in VirtualBox 3.0.12.

[GeneralMaximus]

Always center the edit description window on screen.

[yourpalal]

First of all, thanks for looking in to this!

I don't think centering the NamePanel every single time it appears is the best way to solve this problem. For one thing, there are mechanisms in place in Launchbox that save the frame of the NamePanel, so that its location and size persist, even between boots. With this patch, you lost that functionality, but the code that actually carries out those actions (saving/loading the frame and so on) is still active.

One of the factors contributing to the undesired behaviour here is the make_sure_frame_is_on_screen() function (in support.cpp), which, if the frame is off to the left top (as fNamePanelFrame is, when it isn't loaded from the settings file) places the frame in the top left corner. Preferably, when fNamePanelFrame is invalid, the NamePanel would be placed near the LaunchBox window, instead of the top left corner.

[GeneralMaximus]

Turns out the window was not really off the screen. make_sure_frame_is_on_screen just needed to take window borders into account when calculating the left and top edges of the window. Adding an offset of 5.0 fixes the issue.

Is there a way to get the border width programmatically instead of hardcoding the value?

[anevilyak]

Replying to GeneralMaximus:

Is there a way to get the border width programmatically instead of hardcoding the value?

If I recall correctly, you can retrieve that via BWindow::GetDecoratorSettings(), c.f. ​http://dev.haiku-os.org/browser/haiku/trunk/headers/os/interface/Window.h#L210

[stippi]

I think the solution should be to open the name panel near the LaunchBox panel for which the request is being made. Nothing should be saved in the settings except perhaps the user changed window size.

[stippi]

I've solved the problem differently in hrev42975 by placing the window near the mouse and to the side of the pad window that has enough room.