[intel] can't find boot volume after r38970 (regression)

[diver]

User ​kim1963 reports that Haiku doesn't boot for him since hrev38970 (#6487)
Forum thread: ​http://qube.ru/forums/chto-sdelali-s-38970-i-dalee-sborkami
Google translate: ​link

He is able to boot current revisions after replacing intel partition add-on from hrev38969.

[luroh]

Perhaps bebop has an idea what's going on here.

[bebop]

From what I understand from the google translation, it seems like the boot loader is not finding the partition, is this correct? If so I don't think that any changes to the add-on could have broken this. If this is not the case, a syslog and/or a copy of the mbr would be helpful.

[bonefish]

Replying to bebop:

From what I understand from the google translation, it seems like the boot loader is not finding the partition, is this correct? If so I don't think that any changes to the add-on could have broken this.

The add-on code for scanning the partitions is also compiled for the boot loader. And as I understand the translation, he replaced both the kernel add-on and the boot loader with their old versions to get Haiku to boot again.

[siarzhuk]

He has tested his system using hrev39648 with following roll-back changes:

Index: PartitionMap.cpp 
=================================================================== 
--- PartitionMap.cpp    (revision 39648) 
+++ PartitionMap.cpp    (working copy) 
@@ -834,6 +834,14 @@ 
                off_t nextOffset = 0; 
                for (int32 i = 0; i < byOffsetCount; i++) { 
                        Partition* partition = byOffset[i]; 
+ 
+#if 1                   
+                       if (partition->Offset() < nextOffset) { 
+                               TRACE(("intel: PartitionMap::Check(): overlapping partitions!" 
+                                       "\n")); 
+                               result = false; 
+                               break; 
+#else           
                        if (partition->Offset() < nextOffset && i > 0) { 
                                Partition* previousPartition = byOffset[i - 1]; 
                                off_t previousSize = previousPartition->Size() 
@@ -848,6 +856,7 @@ 
                                                "size to %lld\n", i - 1, previousSize)); 
                                        previousPartition->SetSize(previousSize); 
                                } 
+#endif                          
                        } 
                        nextOffset = partition->Offset() + partition->Size(); 
                } 

The problem disappeared and he has successfully boot his system. The "haiku_loader" and "intel" partition addons were replaced for this test.

[diver]

Whole drive initialized as BFS, hence no mbr.

[bebop]

Thank you for the patch and screen shot. I will look into this on monday, as I am currentley away from my machine.

[diver]

ping.

[Flame]

HaikuOS livecd hrev41245 hybrid 4/2 - new (hrev38970+) intel partition add-on. No mbr.

[Flame]

HaikuOS livecd hrev41245 hybrid 4/2 - new (hrev38970+) intel partition add-on. No mbr.

[waddlesplash]

Still an issue?

[waddlesplash]

No reply.

[nielx]

Remove milestone for tickets with status = closed and resolution != fixed