(reproducible) restoring Defaults triggers app_server crash

[mmadia]

hrev43937 gcc2h.

This is a reproducible bug. If BeZillaBrowser is open, altering the font settings in Appearance will cause app_server to crash into gdb. The following is from serial debugging at the time of the crash. If it helps, a remote KDL session could be set up, by ssh'ing a second box here.

vm_soft_fault: va 0x0 not covered by area in address space
vm_page_fault: vm_soft_fault returned error 'Bad address' on fault at 0xec, ip 0x5b6dd3, write 0, user 1, thread 0x1f1
vm_page_fault: thread "a:495:x-vnd.Haiku-Appearance" (497) in team "app_server" (71) tried to read address 0xec, ip 0x5b6dd3 ("libbe.so_seg0ro" +0x214dd3)
debug_server: Thread 497 entered the debugger: Segment violation
stack trace, current PC 0x5b6dd3  ItemAt__C5BListl + 0xf:
  (0x70eb866c)  0x2b19ae  SetTopTap__9Decoratorl + 0x2a
  (0x70eb869c)  0x2a9195  ReloadDecor__6Window + 0x21d
  (0x70eb86fc)  0x26eeea  ReloadDecor__7DesktopP10DecorAddOn + 0xba
  (0x70eb877c)  0x2b06af  SetDecorator__12DecorManagerG7BStringP7Desktop + 0xb3
  (0x70eb87cc)  0x284d4a  _DispatchMessage__9ServerApplRQ28BPrivate12LinkReceiver + 0xafe
  (0x70eb8ecc)  0x28af6f  _MessageLooper__9ServerApp + 0x18f
  (0x70eb8f7c)  0x27e1ac  _message_thread__13MessageLooperPv + 0x28
  (0x70eb8fac)  0x88b6d3  thread_entry + 0x23
options = 0

[anevilyak]

Looking into it...

[anevilyak]

Fixed in hrev44076.