Scroll bar arrows aren't aligned properly

[jessicah]

The scroll bar arrows aren't aligned properly, so end up looking unbalanced.

Also, whilst fixing the arrows, it would be nice to see the BeOS style arrows make a comeback! Especially the double-arrows.

[diver]

Could you attach a screenshot showing this issue? BTW, you can already enable double-arrows in the Appearance preflet.

[jscipione]

image showing current scrollbar arrows

[leavengood]

To my eye it looks like the down and right arrows are misaligned. Moving them by 1 pixel seems to fix the issue (I did it in a graphics editor.) The code to change is here:

​http://cgit.haiku-os.org/haiku/tree/src/kits/interface/ScrollBar.cpp#n1799

I think adding 1 to r.left for ARROW_RIGHT for all the tri variables will fix the right arrow, and adding 1 to all the r.top for the default case will fix the down arrow.

If no one makes this fix before I get a chance I'll do it. If someone does try to fix it, be sure to test with the double arrows too.

[leavengood]

My suggested fix works perfectly, accept for the fact that there is FakeScrollbar within the Appearance preflet, with the exact same freaking code.

Since WebPositive also needs to render scrollbar arrows we need to move the code into ControlLook.

[leavengood]

Fixed in hrev45334.

[leavengood]

Well strictly speaking, it was fixed here:

​http://cgit.haiku-os.org/haiku/commit/?id=f9b1a47fa329a440024cfcb45a82841ff6961f42