Ticket #10367: 0001-Coverity-CID-1032247-and-1032248-unchecked-return.2.patch

File 0001-Coverity-CID-1032247-and-1032248-unchecked-return.2.patch, 1.1 KB (added by noryb009, 10 years ago)

  • src/kits/storage/FileIO.cpp 

    From 8e46497089b4752e5a910e1451d7af44e9d85cfc Mon Sep 17 00:00:00 2001
From: noryb009 <noryb009@hotmail.com>
Date: Fri, 3 Jan 2014 00:39:34 -0500
Subject: [PATCH] Coverity CID 1032247 and 1032248: unchecked return

The return value of fseeko should be checked. If below 0, an
error occured, and errno is set to indicate the error.
---
 src/kits/storage/FileIO.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/kits/storage/FileIO.cpp b/src/kits/storage/FileIO.cpp
index 439f836..ec23d7b 100644
    a b BFileIO::ReadAt(off_t position, void* buffer, size_t size)  
    5555    ssize_t result = BFileIO::Read(buffer, size);
    5656
    5757    // seek back
    58     fseeko(fFile, oldPosition, SEEK_SET);
     58    if (fseeko(fFile, oldPosition, SEEK_SET) < 0)
     59        return errno;
    5960
    6061    return result;
    6162}
    … … BFileIO::WriteAt(off_t position, const void* buffer, size_t size)  
    7374    ssize_t result = BFileIO::Write(buffer, size);
    7475
    7576    // seek back
    76     fseeko(fFile, oldPosition, SEEK_SET);
     77    if (fseeko(fFile, oldPosition, SEEK_SET) < 0)
     78        return errno;
    7779
    7880    return result;
    7981}