Ticket #2963: 0002-tcp-wait-for-connection-to-complete-before-notifying.patch

src/add-ons/kernel/network/protocols/tcp/TCPEndpoint.cpp

@@ -320 +320 @@
 static inline bool
 is_writable(tcp_state state)
 {
-    return state == SYNCHRONIZE_SENT || state == SYNCHRONIZE_RECEIVED
-        || state == ESTABLISHED || state == FINISH_RECEIVED;
+    return state == ESTABLISHED || state == FINISH_RECEIVED;
+}
+
+
+static inline bool
+is_establishing(tcp_state state)
+{
+    return state == SYNCHRONIZE_SENT || state == SYNCHRONIZE_RECEIVED;
 }
 
 
@@ -786 +792 @@
         return ENOTCONN;
     if (fState == LISTEN)
         return EDESTADDRREQ;
-    if (!is_writable(fState)) {
+    if (!is_writable(fState) && !is_establishing(fState)) {
         // we only send signals when called from userland
         if (gStackModule->is_syscall())
             send_signal(find_thread(NULL), SIGPIPE);
@@ -812 +818 @@
                 return posix_error(status);
             }
 
-            if (!is_writable(fState)) {
+            if (!is_writable(fState) && !is_establishing(fState)) {
                 // we only send signals when called from userland
                 if (gStackModule->is_syscall())
                     send_signal(find_thread(NULL), SIGPIPE);
@@ -873 +879 @@
 
     if (is_writable(fState))
         available = fSendQueue.Free();
+    else if (is_establishing(fState))
+        available = 0;
     else
         available = EPIPE;
 
@@ -1182 +1190 @@
     }
 
     fSendList.Signal();
+    gSocketModule->notify(socket, B_SELECT_WRITE, fSendQueue.Free());
 }
 
 
@@ -2185 +2194 @@
         if (is_writable(fState)) {
             // notify threads waiting on the socket to become writable again
             fSendList.Signal();
-            gSocketModule->notify(socket, B_SELECT_WRITE, fSendQueue.Used());
+            gSocketModule->notify(socket, B_SELECT_WRITE, fSendQueue.Free());
         }
 
         if (fCongestionWindow < fSlowStartThreshold)