Ticket #6789: tcp-wrong-comparison.patch

src/add-ons/kernel/network/protocols/tcp/tcp.cpp

@@ -198 +198 @@
                 length = 1;
                 break;
             case TCP_OPTION_MAX_SEGMENT_SIZE:
-                if (option->length == 4 && (size - 4) >= 0)
+                if (option->length == 4 && size >= 4)
                     segment.max_segment_size = ntohs(option->max_segment_size);
                 break;
             case TCP_OPTION_WINDOW_SHIFT:
-                if (option->length == 3 && (size - 3) >= 0) {
+                if (option->length == 3 && size >= 3) {
                     segment.options |= TCP_HAS_WINDOW_SCALE;
                     segment.window_shift = option->window_shift;
                 }
                 break;
             case TCP_OPTION_TIMESTAMP:
-                if (option->length == 10 && (size - 10) >= 0) {
+                if (option->length == 10 && size >= 10) {
                     segment.options |= TCP_HAS_TIMESTAMPS;
                     segment.timestamp_value = option->timestamp.value;
                     segment.timestamp_reply =
@@ -216 +216 @@
                 }
                 break;
             case TCP_OPTION_SACK_PERMITTED:
-                if (option->length == 2 && (size - 2) >= 0)
+                if (option->length == 2 && size >= 2)
                     segment.options |= TCP_SACK_PERMITTED;
         }