Ticket #9841: reduce_flicker_v2.patch

src/apps/debugger/user_interface/gui/team_window/SourceView.cpp

@@ -1045 +1045 @@
     fScrollRunner(NULL),
     fMarkerManager(manager)
 {
-    SetViewColor(ui_color(B_DOCUMENT_BACKGROUND_COLOR));
+    SetViewColor(B_TRANSPARENT_COLOR);
     fTextColor = ui_color(B_DOCUMENT_TEXT_COLOR);
     SetFlags(Flags() | B_NAVIGABLE);
 }
@@ -1085 +1085 @@
 void
 SourceView::TextView::Draw(BRect updateRect)
 {
-    if (fSourceCode == NULL)
+    if (fSourceCode == NULL) {
+        SetLowColor(ui_color(B_DOCUMENT_BACKGROUND_COLOR));
+        FillRect(updateRect, B_SOLID_LOW);
         return;
+    }
 
     // get the lines intersecting with the update rect
     int32 minLine, maxLine;
@@ -1101 +1104 @@
     SourceView::MarkerManager::InstructionPointerMarker* ipMarker;
     int32 markerIndex = 0;
     for (int32 i = minLine; i <= maxLine; i++) {
-        SetLowColor(ViewColor());
+        SetLowColor(ui_color(B_DOCUMENT_BACKGROUND_COLOR));
         float y = i * fFontInfo->lineHeight;
         BString lineString;
         _FormatLine(fSourceCode->LineAt(i), lineString);
 
+        FillRect(BRect(0.0, y, kLeftTextMargin, y + fFontInfo->lineHeight),
+            B_SOLID_LOW);
         for (int32 j = markerIndex; j < markers.CountItems(); j++) {
             marker = markers.ItemAt(j);
              if (marker->Line() < (uint32)i) {
@@ -1123 +1128 @@
 
                 } else
                     SetLowColor(255, 255, 0, 255);
-                FillRect(BRect(kLeftTextMargin, y, Bounds().right,
-                    y + fFontInfo->lineHeight), B_SOLID_LOW);
                 break;
              } else
                 break;
         }
 
+        FillRect(BRect(kLeftTextMargin, y, Bounds().right,
+            y + fFontInfo->lineHeight), B_SOLID_LOW);
         DrawString(lineString,
             BPoint(kLeftTextMargin, y + fFontInfo->fontHeight.ascent));
     }
@@ -2053 +2058 @@
 
     fMarkerManager->SetStackTrace(fStackTrace);
     fMarkerView->SetStackTrace(fStackTrace);
-    fTextView->Invalidate();
 }
 
 
 void
 SourceView::SetStackFrame(StackFrame* stackFrame)
 {
+    TRACE_GUI("SourceView::SetStackFrame(%p)\n", stackFrame);
     if (stackFrame == fStackFrame)
         return;
 

src/apps/debugger/user_interface/gui/team_window/StackTraceView.cpp

@@ -1 +1 @@
 /*
  * Copyright 2009-2012, Ingo Weinhold, ingo_weinhold@gmx.de.
- * Copyright 2011, Rene Gollent, rene@gollent.com.
+ * Copyright 2011-2013, Rene Gollent, rene@gollent.com.
  * Distributed under the terms of the MIT License.
  */
 
@@ -12 +12 @@
 #include <new>
 
 #include <ControlLook.h>
+#include <MessageRunner.h>
+#include <Window.h>
 
 #include "table/TableColumns.h"
 
@@ -23 +25 @@
 #include "UiUtils.h"
 
 
+enum {
+    MSG_CLEAR_STACK_TRACE   = 'clst'
+};
+
+
 // #pragma mark - FramesTableModel
 
 
@@ -107 +114 @@
     fStackTrace(NULL),
     fFramesTable(NULL),
     fFramesTableModel(NULL),
+    fTraceUpdateRunner(NULL),
     fListener(listener)
 {
     SetName("Stack Trace");
@@ -149 +157 @@
 {
     if (stackTrace == fStackTrace)
         return;
-
-    if (fStackTrace != NULL)
-        fStackTrace->ReleaseReference();
-
-    fStackTrace = stackTrace;
-
-    if (fStackTrace != NULL)
-        fStackTrace->AcquireReference();
-
-    fFramesTableModel->SetStackTrace(fStackTrace);
+    else if (stackTrace == NULL) {
+        if (fTraceUpdateRunner == NULL) {
+            BMessage message(MSG_CLEAR_STACK_TRACE);
+            message.AddPointer("currentTrace", fStackTrace);
+            fTraceUpdateRunner = new(std::nothrow) BMessageRunner(this,
+                message, 250000, 1);
+            if (fTraceUpdateRunner != NULL
+                && fTraceUpdateRunner->InitCheck() != B_OK) {
+                delete fTraceUpdateRunner;
+                fTraceUpdateRunner = NULL;
+            }
+        }
+    } else {
+        delete fTraceUpdateRunner;
+        fTraceUpdateRunner = NULL;
+        _SetStackTrace(stackTrace);
+    }
 }
 
 
@@ -205 +220 @@
 
 
 void
+StackTraceView::MessageReceived(BMessage* message)
+{
+    switch (message->what) {
+        case MSG_CLEAR_STACK_TRACE:
+        {
+            StackTrace* currentStackTrace;
+            if (message->FindPointer("currentTrace",
+                    reinterpret_cast<void**>(&currentStackTrace))
+                    == B_OK && currentStackTrace == fStackTrace) {
+                _SetStackTrace(NULL);
+            }
+            break;
+        }
+        default:
+        {
+            BGroupView::MessageReceived(message);
+            break;
+        }
+    }
+}
+
+
+void
 StackTraceView::TableSelectionChanged(Table* table)
 {
     if (fListener == NULL)
@@ -243 +281 @@
 }
 
 
+void
+StackTraceView::_SetStackTrace(StackTrace* stackTrace)
+{
+    if (fStackTrace != NULL)
+        fStackTrace->ReleaseReference();
+
+    fStackTrace = stackTrace;
+
+    if (fStackTrace != NULL)
+        fStackTrace->AcquireReference();
+
+    fFramesTableModel->SetStackTrace(fStackTrace);
+}
+
+
 // #pragma mark - Listener
 
 

src/apps/debugger/user_interface/gui/team_window/StackTraceView.h

@@ -11 +11 @@
 #include "Team.h"
 
 
+class BMessageRunner;
 class StackFrame;
 
 
@@ -33 +34 @@
             void                LoadSettings(const BMessage& settings);
             status_t            SaveSettings(BMessage& settings);
 
+    virtual void                MessageReceived(BMessage* message);
+
 private:
             class FramesTableModel;
 
@@ -42 +45 @@
 
             void                _Init();
 
+            void                _SetStackTrace(StackTrace* stackTrace);
+
 private:
             StackTrace*         fStackTrace;
             Table*              fFramesTable;
             FramesTableModel*   fFramesTableModel;
+            BMessageRunner*     fTraceUpdateRunner;
             Listener*           fListener;
 };