Opened 9 years ago

Closed 9 years ago

#11394 closed bug (fixed)

[PATCHes] BToolbar rework, standard icons, etc.

Reported by: waddlesplash Owned by: axeld
Priority: low Milestone: Unscheduled
Component: Kits/Interface Kit Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

(Don't close this ticket after applying patches, as I've got quite a bit that I'm posting here a few at a time so it's easier to review & revise them.)

Everything else should be pretty much self-explanatory.

Attachments (3)

0001-ToolBarView-rename-to-BToolbar-and-move-to-libshared.patch​ (21.6 KB ) - added by waddlesplash 9 years ago.
0002-BToolbar-Allow-the-toolbar-s-orientation-to-be-set-b.patch​ (2.4 KB ) - added by waddlesplash 9 years ago.
0003-Button-add-a-SetIcon-resourceID-convenience-method.patch​ (3.5 KB ) - added by waddlesplash 9 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 by waddlesplash, 9 years ago

patch: 0 → 1

by waddlesplash, 9 years ago

Attachment: 0001-ToolBarView-rename-to-BToolbar-and-move-to-libshared.patch​ added

comment:2 by jessicah, 9 years ago

patch: 1 → 0

Applied in hrev48216.

Last edited 9 years ago by jessicah (previous) (diff)

comment:3 by waddlesplash, 9 years ago

patch: 0 → 1

by waddlesplash, 9 years ago

Attachment: 0002-BToolbar-Allow-the-toolbar-s-orientation-to-be-set-b.patch​ added

comment:4 by jessicah, 9 years ago

patch: 1 → 0
Version 0, edited 9 years ago by jessicah (next)

comment:5 by waddlesplash, 9 years ago

patch: 0 → 1

comment:6 by jessicah, 9 years ago

I'm not completely confident reviewing this one. I'd rather see the likes of stippi or pulkomandy review.

However, a couple comments:

  1. don't you also need to address padding for this class?
  2. the doxygen documentation looks incorrect; it has BControl::SetIcon rather than BBitmap::SetIcon

by waddlesplash, 9 years ago

Attachment: 0003-Button-add-a-SetIcon-resourceID-convenience-method.patch​ added

comment:7 by waddlesplash, 9 years ago

patch: 1 → 0

comment:8 by waddlesplash, 9 years ago

patch: 0

On second thought, ignore that patch...

comment:9 by waddlesplash, 9 years ago

patch: → 0
Resolution: → fixed
Status: new → closed

BToolBar API is mostly OK at this point, so closing as resolved. (The only unapplied patch here should not be applied.)

Note: See TracTickets for help on using tickets.