Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#1222 closed bug (fixed)

check if AboutHaiku lists an acknowledgment for all packages

Reported by: wkornewald Owned by: nielx
Priority: blocker Milestone: R1/alpha1
Component: - General Version: R1/pre-alpha1
Keywords: Cc: wkornewald, axeld
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

Check all libraries and applications in our repository and make sure that we have an acknowledgment for them in the appropriate place (e.g., AboutHaiku application).

Maybe someone from the community could do this as it doesn't require coding skills? It would be sufficient to know what has to be added, so the devs can do the rest.

Attachments (4)

AboutSystem.cpp.diff (5.2 KB) - added by scottmc 11 years ago.
Here is my first .diff for this ticket.
AboutSystem.cpp.diff#2 (3.7 KB) - added by scottmc 11 years ago.
diff for 2nd round of updates.
AboutSystem.cpp.diff2 (3.4 KB) - added by scottmc 11 years ago.
AboutSystem.diff2 (3.8 KB) - added by scottmc 11 years ago.

Download all attachments as: .zip

Change History (32)

comment:1 Changed 12 years ago by mmadia

attempting to document this locally. i'm starting in src/system/libroot and /runtime_loader

comment:2 Changed 12 years ago by axeld

Owner: axeld deleted

comment:3 Changed 11 years ago by nielx

Milestone: R1R1/alpha1
Priority: criticalblocker

Moving this to the alpha 1 milestone, as stippi and others acknowledged on the development mailing list on the thread called 'Haiku alpha 1 release'.

comment:4 Changed 11 years ago by emitrax

What's the status of this ticket? And what do you think it is the best way to proceed for a non-developer user?

comment:5 Changed 11 years ago by nielx

Funnily enought I just thought about this ticket too, this morning while I was sitting in my car. There once was a thread on the mailing list on how to do this. Here's my take on the problem: let's just make a list of all non-Haiku software that is currently used. Put this in a file in the root of the trunk and list the:

  • Name of the package and the version
  • The license
  • The copyrightholder. If there is more than one, just put down 'several copyright holders'.
  • The URL where more information on the package can be found.

The build system would 'cat' this file into a C-file, which is imported into the AboutHaiku application.

This will not make these copyright statements very appealing and sexy, but remember: it is a legal requirement, rather than something our users would look at.

(That's just my take). A non-coder could start compiling that list.

comment:6 in reply to:  5 Changed 11 years ago by bonefish

Cc: bonefish removed

Replying to nielx:

Funnily enought I just thought about this ticket too, this morning while I was sitting in my car. There once was a thread on the mailing list on how to do this. Here's my take on the problem: let's just make a list of all non-Haiku software that is currently used. Put this in a file in the root of the trunk and list the:

...

Well, in the end it doesn't make much difference whether you list the files in a separate file or in the AboutSystem sources. The main work is compiling the list. Thanks for attacking this.

comment:7 Changed 11 years ago by scottmc

I've started looking into this and here's what I have turned up so far. Maybe we should create a format of the file in which this should all be put so we can make sure we are capturing all of the required info. Perhaps list Package name, License, Version, Website, etc... In many cases there are newer versions available than are currently in the Haiku source tree. This can be a starting point, I'm sure there's lots more to add to this list.

gdb 6.7.1 acpica 20080321 ncurses 5.6 unrar 3.7.1 7zip LGPL 4.57 <- can/should this be added? libpng 1.2.25 libprint libjpeg xmlwf

Already in AboutHaiku freetype 2.3.5 freetype liscense freetype.org ffmpeg ffmpeg.org antigrain.com pdflib pdflib.com mesa3d mesa3d.org glu glut bregion backend xfree86 konatu font expat zlib info-ZIP bzip2 Vi IMproved lp_solve OpenEXR Bullet

in vendor directory:

acpica - Intel atftp - GPL 2 - 0.7 bash - GNU.org - 3.2 coreutils GNU.org - 6.9 cortex - Eric Moon - 1999-2000 docbook oasis-open.org - 4.2 freebsd gdb - GNU.org - 6.3 libxml2 - Daniel Veillard, MIT Licence - 2.6.26 libxslt - Daniel Veillard, MIT Licence - 1.1.17 lpsolve - LGPL - 5.5.0.11 mesa - 1999-2007 Brian Paul - 7.0.2 ncurses - 1998-2004,2005 Free Software Foundation - 5.5 unrar - Alexander Roshal - FreeWare - 3.6.7 yellowtab_extreme2 - 17 December 2005

comment:8 in reply to:  7 Changed 11 years ago by nielx

Replying to scottmc:

I've started looking into this and here's what I have turned up so far. Maybe we should create a format of the file in which this should all be put so we can make sure we are capturing all of the required info. Perhaps list Package name, License, Version, Website, etc... In many cases there are newer versions available than are currently in the Haiku source tree. This can be a starting point, I'm sure there's lots more to add to this list.

I saw on the mailing list you already started adding these to the AboutSystem.cpp file. I guess that's preferred right now, however, as the complexity of the code in our repository increases, it might be a good idea to think about another solution.

comment:9 Changed 11 years ago by nielx

Owner: set to nielx

BTW, if everyone is allright with it, I would like to volunteer to 'assign' the ticket to me so I will coordinate with Scott that his patches end up in the repository.

Will do that tomorrow if no one objects.

Changed 11 years ago by scottmc

Attachment: AboutSystem.cpp.diff added

Here is my first .diff for this ticket.

comment:10 Changed 11 years ago by stippi

I applied your patch in hrev24966. Your work is highly appreciated! Since you have the best overview, do you know if there are (could be) any copyrights missing yet?

comment:11 Changed 11 years ago by scottmc

I should know more in the next week or so. I'm going to go through the bin directory and check each file in there and if anyone else reports any I'll add those in as well. I'd like to close this ticket out by the end of April.

Changed 11 years ago by scottmc

Attachment: AboutSystem.cpp.diff#2 added

diff for 2nd round of updates.

comment:12 Changed 11 years ago by scottmc

Here's the second round of changes, adding libMicro, matroska, tput, SharUtils. I put OpenSound in but don't have the copyright info yet. This will complete this ticket unless someone still spots something that is still missing. I've searching through all of the command line utils in bin and most of the rest of the system. I did not put in the Translators as those have their copyrights built-in to their settings window.

comment:13 Changed 11 years ago by umccullough

I think that currently OpenSound isn't in the Haiku tree, it is only supported as an optional package downloaded from François' server. (So it would basically be no different than the Firefox optional package at this point)

The media node in the tree is all written from scratch and not ported.

comment:14 in reply to:  13 ; Changed 11 years ago by mmu_man

Replying to umccullough:

I think that currently OpenSound isn't in the Haiku tree, it is only supported as an optional package downloaded from François' server. (So it would basically be no different than the Firefox optional package at this point)

Indeed, only the media node is in svn for now. I still need to update the port since they changed the licence from CDDL to BSD.

The media node in the tree is all written from scratch and not ported.

Yes I wrote it.

comment:15 in reply to:  14 Changed 11 years ago by mmu_man

comment:16 Changed 11 years ago by scottmc

Ok, updated the diff2 file, so it's ready to add. I have Opensound in there, with the copyright and license updated, but it's commented out still. If someone could apply this diff, this ticket can then be closed.

comment:17 in reply to:  16 Changed 11 years ago by nielx

Replying to scottmc:

Ok, updated the diff2 file, so it's ready to add. I have Opensound in there, with the copyright and license updated, but it's commented out still. If someone could apply this diff, this ticket can then be closed.

I will check whether the patch compiles cleanly and whether the formatting is nice tomorrow. I will then commit. Thanks for the effort!

comment:18 Changed 11 years ago by axeld

BTW libMicro is an optional package as well, and doesn't have to be listed this way; the optional packages should now come with proper licensing information.

comment:19 Changed 11 years ago by scottmc

I put cal under FreeBSD and also ftpd, but is ftpd in the image yet? #807 Should I comment out libMicro or just remove it? I'll update the diff file.

Changed 11 years ago by scottmc

Attachment: AboutSystem.cpp.diff2 added

comment:20 in reply to:  18 ; Changed 11 years ago by bonefish

Replying to axeld:

BTW libMicro is an optional package as well, and doesn't have to be listed this way; the optional packages should now come with proper licensing information.

Only the ones that download a zip file, which would contain a description file. That obviously doesn't work for optional packages built from sources in our repository. So I guess I have to add a rule that adds a copyright description after all.

comment:21 Changed 11 years ago by axeld

ftpd is part of Haiku - I've updated ticked #807 now, thanks for the note :-)

comment:22 Changed 11 years ago by nielx

Hi Scott. The patch looks good, but does not apply cleanly on my system. Could you please create a new patch using 'svn diff' and post it here (or perhaps even mail it to me?)

Thanks.

comment:23 Changed 11 years ago by stippi

Scott, I also had problems with your earlier patch and needed to apply it by hand. It looked to me like your editor was replacing tabs with spaces. Could that be what happened?

comment:24 in reply to:  23 Changed 11 years ago by scottmc

Replying to stippi:

Scott, I also had problems with your earlier patch and needed to apply it by hand. It looked to me like your editor was replacing tabs with spaces. Could that be what happened?

That's probably what happened. I'm working on a few different systems here and not sure which one I used when I created this diff. So are you able to make it work or should I recreate it?

Changed 11 years ago by scottmc

Attachment: AboutSystem.diff2 added

comment:25 Changed 11 years ago by scottmc

I updated the diff to include copyright for 7zip, but it's commented out as 7zip isn't in as of yet. The tabs/spacing should be right this time.

comment:26 Changed 11 years ago by scottmc

Here's the detailed, step-by-step instructions for getting and making 7za, the GPL'd command line app for 7zip:

wget http://internap.dl.sourceforge.net/sourceforge/p7zip/p7zip_4.57_src_all.tar.bz2 bunzip2 p7zip_4.57_src_all.tar.bz2 tar -xf p7zip_4.57_src_all.tar cd p7zip_4.57 cp makefile.beos makefile.machine make

then copy the resulting 7za file to your bin directory, it's in p7zip_4.57/bin.

comment:27 Changed 11 years ago by nielx

Resolution: fixed
Status: newclosed

Fixed in hrev25297. Thanks Scott for all the work!

comment:28 in reply to:  20 Changed 11 years ago by bonefish

Replying to bonefish:

Replying to axeld:

BTW libMicro is an optional package as well, and doesn't have to be listed this way; the optional packages should now come with proper licensing information.

Only the ones that download a zip file, which would contain a description file. That obviously doesn't work for optional packages built from sources in our repository. So I guess I have to add a rule that adds a copyright description after all.

Did that in hrev25313. The new rules AddOptionalPackDescriptionToHaikuImage and AddLicenseToHaikuImage can be used in optional package descriptions to add the copyright entries and licenses. I did that for the libMicro optional package (hrev25314).

Note: See TracTickets for help on using tickets.