Opened 4 years ago

Last modified 14 months ago

#12608 reopened bug

BTextControl Centering is Broken

Reported by: AGMS Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits/Interface Kit Version: R1/Development
Keywords: BTextControl, Center Cc: agmsmith@…
Blocked By: Blocking:
Has a Patch: yes Platform: All

Description

Supposedly centered text is actually a little bit to the left of center. Stays proportionally to the left even when the text box is resized.

Attachments (4)

BTextControlCenteringTest.png (19.6 KB ) - added by AGMS 4 years ago.
Shows BeOS and Haiku OS examples of centered text, and what happens when the text box is stretched wider.
CenteringBug.cpp (1.3 KB ) - added by AGMS 4 years ago.
Code which creates the examples of centered BTextControls.
fix-text-width.patch (865 bytes ) - added by hyche 22 months ago.
fix-align.patch (1022 bytes ) - added by hyche 22 months ago.

Download all attachments as: .zip

Change History (10)

by AGMS, 4 years ago

Shows BeOS and Haiku OS examples of centered text, and what happens when the text box is stretched wider.

by AGMS, 4 years ago

Attachment: CenteringBug.cpp added

Code which creates the examples of centered BTextControls.

comment:1 by axeld, 2 years ago

Owner: changed from axeld to nobody
Status: newassigned

by hyche, 22 months ago

Attachment: fix-text-width.patch added

comment:2 by hyche, 22 months ago

Has a Patch: set

comment:3 by AGMS, 22 months ago

Good find!

comment:4 by hyche, 22 months ago

the above patch follows up the old patch

Last edited 22 months ago by hyche (previous) (diff)

by hyche, 22 months ago

Attachment: fix-align.patch added

comment:5 by waddlesplash, 22 months ago

Resolution: fixed
Status: assignedclosed

First patch applied by PulkoMandy in hrev51603, second applied by me in hrev51611. Thanks!

comment:6 by waddlesplash, 14 months ago

Resolution: fixed
Status: closedreopened

Patches reverted in hrev52117 due to edge-case issues.

Note: See TracTickets for help on using tickets.