id,summary,reporter,owner,description,type,status,priority,milestone,component,version,resolution,keywords,cc,blockedby,blocking,platform 12743,[Patch] MailProtocol.cpp: fix gcc6 build,mt,czeidler,"Gcc6 warns '-Werror=nonnull-compare' in some functions. It seems it is better to use BAutolock(this) than Blocker(this). {{{ C++ /home/haiku/haiku/haiku/generated-gcc6/objects/haiku/x86/release/kits/mail/ssl/MailProtocol.o /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp: In member function 'bool BMailProtocol::AddFilter(BMailFilter*)': /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp:91:21: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare] BLocker locker(this); ^ /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp: In member function 'int32 BMailProtocol::CountFilter() const': /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp:99:21: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare] BLocker locker(this); ^ /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp: In member function 'BMailFilter* BMailProtocol::FilterAt(int32) const': /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp:107:21: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare] BLocker locker(this); ^ /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp: In member function 'BMailFilter* BMailProtocol::RemoveFilter(int32)': /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp:115:21: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare] BLocker locker(this); ^ /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp: In member function 'bool BMailProtocol::RemoveFilter(BMailFilter*)': /home/haiku/haiku/haiku/src/kits/mail/MailProtocol.cpp:123:21: error: nonnull argument 'this' compared to NULL [-Werror=nonnull-compare] BLocker locker(this); ^ cc1plus: all warnings being treated as errors }}} ",bug,closed,normal,Unscheduled,Kits/Mail Kit,R1/Development,fixed,,,,,All