Opened 6 years ago

Closed 5 years ago

Last modified 4 years ago

#14138 closed bug (fixed)

haiku/build/jam/repositories/HaikuPorts/x86_gcc2: update libedit_x86

Reported by: fbrosson Owned by: nobody
Priority: normal Milestone: R1/beta2
Component: - General Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

I'm trying to use gerrit but I'm getting this error: "You have not registered any email addresses."

Could you please attach "fbrosson at users.noreply.github.com" to the SSH key I have as configured in review.haiku-os.org ?

BTW, the commit I'd like to push is:

https://git.haiku-os.org/haiku/commit/?id=b141a7eb62f4b959a08fc83a0dddb80c3ee5a1a4

Thanks!

P.S. I guess this not the right process to submit patches. I'm trying to figure out what the correct one is.

Change History (6)

comment:1 by pulkomandy, 6 years ago

The correct process is submitting at review.haiku-os.org but you need your email address activated there (turns out trying to reuse peoples github accounts may not make things as simple as we expected,..)

Moreover for updating packages there is some manual work by haiku devs needed, so we can't apply the patch directly anyway (there is a script that automatically syncs with haikuports and changes the files in the haiku repo)

comment:2 by fbrosson, 6 years ago

Thanks @PulkoMandy :)

Actually, the version bump for libedit (from 2015_03_21_3.1-8 to 20170329_3.1-1) was done in https://github.com/haiku/haiku/commit/9e13d1b8d1e1010a09aeb63bda4ca231ff533f3a for x86_gcc2 primary arch (lines 82 and 93) but not for x86 secondary arch (lines 200 and 201). So I guess something went wrong with the script ;)

Regading the e-mail topic, in wiki/CodingGuidelines/SubmittingPatches I read this:

Note: If, after creating an account, you do not have any email addresses attached, please create a ticket under the component Website/Gerrit and specify your GitHub username and the email address you would like the administrators to set for you.

But I haven't found yet how to open a ticket under the component Website/Gerrit.

Can you help me getting my fbrosson at users.noreply.github.com e-mail attached to my gerrit account (ID=1000056) on review.haiku-os.org ? Thanks a lot!

Version 0, edited 6 years ago by fbrosson (next)

comment:3 by fbrosson, 6 years ago

Sorry, I was looking for a Website/Gerrit page in the wrong site...

I've just created the ticket: #14139

comment:4 by fbrosson, 6 years ago

I guess we should close this ticket.

Or maybe change its description to:

"libedit_x86-20170329_3.1 package missing on x86_gcc2 (hybrid)"

comment:5 by waddlesplash, 5 years ago

Resolution: fixed
Status: newclosed

The _x86 package missing (if it still is) will be a buildmaster or HaikuPorts problem, not a Haiku problem. So this is indeed fixed.

comment:6 by nielx, 4 years ago

Milestone: UnscheduledR1/beta2

Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone

Note: See TracTickets for help on using tickets.