Changes between Initial Version and Version 1 of Ticket #14961


Ignore:
Timestamp:
Mar 15, 2019, 7:39:35 PM (3 years ago)
Author:
waddlesplash
Comment:

Did the first pass on the first few files.

safemode_settings does not do any access checks; any application is allowed to read (not write, that can't be done via syscall) safemode settings. I think that's OK? Otherwise the file is fine.

system_profiler also does not seem to do permissions checks. I think that we expose quite a lot of information in that, so it should probably only allow root to run the profiler?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14961 – Description

    initial v1  
    11Here's a full list of source files containing syscall implementations:
    22
    3  * src/system/kernel/UserTimer.cpp
    4  * src/system/kernel/arch/arm/arch_atomic32.cpp
    5  * src/system/kernel/arch/arm/arch_atomic64.cpp
    6  * src/system/kernel/arch/m68k/arch_atomic.cpp
    7  * src/system/kernel/arch/x86/arch_system_info.cpp
    8  * src/system/kernel/arch/x86/syscalls_compat.cpp
    9  * src/system/kernel/cpu.cpp
    10  * src/system/kernel/debug/BreakpointManager.cpp
    11  * src/system/kernel/debug/debug.cpp
    12  * src/system/kernel/debug/frame_buffer_console.cpp
    13  * src/system/kernel/debug/safemode_settings.cpp
    14  * src/system/kernel/debug/system_profiler.cpp
     3 * OK ~~src/system/kernel/arch/arm/arch_atomic32.cpp~~
     4 * OK ~~src/system/kernel/arch/arm/arch_atomic64.cpp~~
     5 * OK ~~src/system/kernel/arch/m68k/arch_atomic.cpp~~
     6 * OK ~~src/system/kernel/arch/x86/arch_system_info.cpp~~
     7 * OK ~~src/system/kernel/arch/x86/syscalls_compat.cpp~~
     8 * OK ~~src/system/kernel/debug/debug.cpp~~
     9 * OK ~~src/system/kernel/debug/frame_buffer_console.cpp~~
     10 * DISCUSS src/system/kernel/debug/safemode_settings.cpp
     11 * DISCUSS src/system/kernel/debug/system_profiler.cpp
    1512 * src/system/kernel/debug/tracing.cpp
    1613 * src/system/kernel/debug/user_debugger.cpp
    1714 * src/system/kernel/disk_device_manager/ddm_userland_interface.cpp
     15 * src/system/kernel/UserTimer.cpp
     16 * src/system/kernel/cpu.cpp
    1817 * src/system/kernel/elf.cpp
    1918 * src/system/kernel/fs/fd.cpp