Opened 5 years ago

Closed 4 years ago

#15038 closed enhancement (fixed)

Add KeyboardEvent.key and KeyboardEvent.code (DOM2?)

Reported by: sneaky Owned by: pulkomandy
Priority: normal Milestone: R1/beta2
Component: Applications/WebPositive Version: R1/Development
Keywords: webkit Cc:
Blocked By: Blocking:
Platform: All

Description

Some w3c docs:

https://www.w3.org/TR/uievents/#keydown

https://www.w3.org/TR/uievents/#interface-keyboardevent

Nice www demo/test:

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

https://keycode.info/

Why:

Mostly for games. Some of the phaser.io demos didn't work.

I can give other examples in telegram.

Attachments (1)

D2.diff (10.2 KB ) - added by sneaky 5 years ago.
stab at fix

Download all attachments as: .zip

Change History (6)

by sneaky, 5 years ago

Attachment: D2.diff added

stab at fix

comment:1 by sneaky, 5 years ago

nope, dom3 attributes... just referring to title... here's a list for codes https://www.w3.org/TR/2014/WD-DOM-Level-3-Events-code-20140612/#keyboard-key-codes

... This is what I was looking for before...

comment:2 by pulkomandy, 5 years ago

It would be great if you could submit this as a pull request to github.com/haiku/webkit so that you get proper credit for the work. Otherwise I'll jsut apply the patch, which looks ok at a first glance.

Version 0, edited 5 years ago by pulkomandy (next)

comment:3 by korli, 5 years ago

Summary: Add KevboardEvent.key and KeyboardEvent.code (DOM2?)Add KeyboardEvent.key and KeyboardEvent.code (DOM2?)

comment:4 by pulkomandy, 5 years ago

Patch has been merged on WebKit side and will be included in the next haikuwebkit release.

comment:5 by pulkomandy, 4 years ago

Milestone: UnscheduledR1/beta2
Resolution: fixed
Status: newclosed

Took some time but it is released now.

Note: See TracTickets for help on using tickets.