SMAP violation on usb_disk

[Coldfirex]

I plugged in a USB dvd drive to my laptop, inserted an audio CD, opened MediaPlayer (which auto-started a .wav file), I stopped the wav file from playing, and then hit Eject from the file menu. Got SMAP KPL.

Can reproduce. hrev55445

[korli]

Coldfirex, please see ​https://git.haiku-os.org/haiku/tree/src/add-ons/kernel/drivers/disk/usb/usb_disk/usb_disk.cpp#n1802

basically it should be like: ​https://git.haiku-os.org/haiku/tree/src/add-ons/kernel/generic/scsi_periph/io.cpp#n406

			if (IS_USER_ADDRESS(buffer)) {
				if (user_memcpy(buffer, &ready, sizeof(status_t)) != B_OK)
					return B_BAD_ADDRESS;
			} else if (is_called_via_syscall()) {
				return B_BAD_ADDRESS;
			} else
				*(status_t *)buffer = ready;

[Coldfirex]

Korli: Thanks for pointing out the area, but I will need to defer to someone else on making this change.

[korli]

pushed a change to be tested: ​https://review.haiku-os.org/c/haiku/+/4505

available here: ​https://haiku.movingborders.es/testbuild/If594129a6e16b50c314efa2a7bb1d18e01cdad15/1/hrev55452/x86_64/

[Coldfirex]

Thanks! How do I test this?

[korli]

Replying to Coldfirex:

Thanks! How do I test this?

Download the iso and boot on USB.

[Coldfirex]

Fixed! And it actually ejects the usb disc drive with or without a disc inserted. :)

[korli]

Thanks for the test and feedback! Applied in hrev55480