Can't reset default background colour in Background Preferences

[haiqu]

New functioanlity in Haiku allows the user to select a background colour using RGB sliders. There is a "Revert" button which goes back to the previous colour selected, but no "Default" button to reset to the original colour once it is lost.

There is a workaround. By setting the number of workspace to +1 and moving to the new one, you can see that the values are 51, 102, 152 and then correct the problem. But this probably wouldn't occur to a new user.

[axeld]

That's obviously the Background preferences...

[deejam]

+1 on this one. There should be a Defaults button that resets Backgrounds to its default setting.

[humdinger]

You're missing a .AddStrut(B_USE_DEFAULT_ITEME_SPACING) between the Defaults and Revert buttons.

And the Defaults button should pretty much always be enabled. Now it's disabling when the user presses "Apply" and only becomes enabled again when the colour picker is manipulated. One could use the DesktopColor() call on the current BScreen to see if the defaults are already set and disable the Defaults button if that's the case. But personally, I wouldn't be bothered if the button were just always enabled...

[valzant]

Thank you for code review. I am adding a second patch, on top of the previous, with fixes.

[humdinger]

I'm sorry I'm so piece-meal with my comments... I just realized that "Defaults" is not only about the background colours, other settings have to be considered as well. What's the default placement? Icon label outline is "off" I'd say.

Now, what about the image? Is setting to "None" correct? Or do we have to revert to the manually placed Haiku background? Where is that background in the Haiku image? Can anyone shed some light?

[pulkomandy]

Yes, a default button should revert to the default settings. That makes some things a little tricky however:

• Desktop color: you can get it from ui_color, so no problem
• Icon outline: I don't remember what the default setting is, but it should be restored
• Background: there is a default background, but only in "official" distro compatibility mode. I think the best way here would be to detect if the file is available, and only if it is, restore it. Otherwise, set no background at all. The logo is in system/data/artwork (part of the haiku package), there are a white and a black version. The white one is used by default.

[Janus]

This is very tricky the user can change the Background of folders. If a user changes some folders, after that changes some workspaces. What is the expected "Default" button behavior?

[humdinger]

I'd say that is determined with the pop-up at the top. If it's all/current workspace, it applies the workspace defaults, if it's set to folder it applies the folder defaults (no image, white).

[Janus]

Replying to humdinger:

I'd say that is determined with the pop-up at the top. If it's all/current workspace, it applies the workspace defaults, if it's set to folder it applies the folder defaults (no image, white).

I was thinking more of the revert button.

[humdinger]

Replying to Janus:

I was thinking more of the revert button.

We only have very few preferences that aren't live and have an "Apply" button instead. In "Screen" the "Revert" button reverts to the state when the panel was opened. In "Email" the "Revert" button seems to revert the change since the "Apply" button was last clicked.

I'd go with option 1: revert to the state when the panel was opened.

[pulkomandy]

Patch migrated to Gerrit: ​https://review.haiku-os.org/#/c/80/