Changes between Initial Version and Version 1 of Ticket #5113


Ignore:
Timestamp:
Dec 12, 2009, 5:54:28 PM (14 years ago)
Author:
axeld
Comment:

First of all thanks for the patch.

But then, please attach a diff instead of of copying it into the ticket description next time. Also, changes like: 

 }
 
-
 void
 _start(void)

shouldn't be found in such a patch, as this introduces a style violation in previously fine code.

Then: 

+			case 'w':
+			case 'W':
+				warm_boot();
 			case 0:

There is a "break;" missing - even if warm_boot() is not supposed to return, it's just good style.

Finally, what is the purpose of this patch? What does it do, and what does one gain?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #5113 – Description

    initial v1  
    33Press 'W' or 'w' for warm boot.
    44
     5{{{
    56Index: src/system/boot/platform/bios_ia32/keyboard.h
    67===================================================================
    … …  
    103104        parse_multiboot_commandline(&args);
    104105 
     106}}}