get_nth_pci_info missing

[andrewbachmann]

I was trying to run BeRometer to do some performance testing and it complains about this symbol missing. The symbol is in libroot.so on BeOS R 5.

[axeld]

But it's also private API. Nevertheless, a nice API to enumerate the hardware (something more/better than the info that is in the device tree) would be appreciated.

[andrewbachmann]

Replying to axeld:

But it's also private API. Nevertheless, a nice API to enumerate the hardware (something more/better than the info that is in the device tree) would be appreciated.

Yeah, it's private API. Some other programs are also using it. Should we add a stub for the method/symbol and get around to flushing it out later when doing the stack of nice-to-haves?

[BeSman]

BeRometer works well now, but it needs a libmail from BeOS R5 becose it using some undocumented API from it, patch for haiku`s libmail is work-in-progress

[siarzhuk]

Replying to BeSman:

BeRometer works well now, but it needs a libmail from BeOS R5 becose it using some undocumented API from it, patch for haiku`s libmail is work-in-progress

long get_nth_pci_info(long index,pci_info *info) 
{ 
    pci_module_info *mod_info; 
    if(mod_info->get_nth_pci_info(index,info)) 
        return B_NO_ERROR; 
    else  
        return B_ERROR; 
}

Please explain what are you trying to do here. Thanks.

BTW, read the Coding Guidelines too. ;-)

[BeSman]

Im provided a BeOS R5 compatible callback for get_nth_pci_info() function which we have in pci bus manager but not in libroot.so

[phoudoin]

mod_info is unset, your code will most probably crash at pointer dereference on next line. You clearly never test this code ;-)

[diver]

Added stub for get_nth_pci_info. BeRometer works now.

[Premislaus]

Replying to diver:

Thanks! BeRometer works good, but whetstone test deadlocks Haiku ;).

Too bad that this program does not save the results in columns. And that does not save what means another results.

Could you check this program - ​BeBench?

[Premislaus]

Replying to diver:

​https://www.haiku-os.org/community/forum/haiku_results_berometer_benchmark

[jackburton]

Can we close this ?

[diver]

BeRometer binary with a patched libroot.so. Whetstone test deadlocks Haiku.

[pulkomandy]

Patch applied in hrev50554. BeRoMeter now works. I didn't retry the whetstone test. I also noticed that the BeRoMeter installer complains that I have only -94MB of RAM. I guess it overflows somewhere when there are more than 2GB on the system, but I could test diver's binary.