BNetEndpoint busted

[Duggan]

BNetEndpoint had issues with SetNonBlocking(), Receive(), ReceiveFrom(), and IsDataPending() as far as blocking when it wasn't suppose to. I believe I've fixed it, but if not let me know. Patch attached.

[Duggan]

diff of changes made to fix this ticket

[Duggan]

Oh one more thing.... maybe I need to work a little more on it as it would appear looking at it that SetNonBlocking doesn't set fTimeout itself so you'd have to call SetTimeout explicitly to make it non-blocking... comments?

[mmadia]

... guessing that Axel would be a good owner for this.

[axeld]

Sure, I just won't have the time to look into it for the next two weeks, and after that, I will probably have forgotten about it ;-)

[Duggan]

The BeBook doesn't state what a timeout of 0 means, but my interpretation is that it waits 0 units of time before timing out. Since the BeBook isn't specific I would think that leaves it up to interpretation...

[anevilyak]

given that it specifically indicates that -1 = no timeout, it seems reasonable to assume that 0 would mean don't wait.

[Duggan]

Sorry, I should have been more specific. For SetTimeout() you are correct, but for IsDataPending() a timeout of 0 is undefined.

[Duggan]

Misread what you said but I think you might have misspoke too, I'm not sure... In some cases I believe 0 is defined as meaning "wait indefinitely" but there's already a constant assigned for that and the value certainly isn't 0.

[pulkomandy]

Applied in hrev50557.