Opened 7 years ago

Closed 4 years ago

#8745 closed bug (fixed)

Tracker not showing image dimensions.

Reported by: jstressman Owned by: axeld
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/Development
Keywords: Cc:
Blocked By: Blocking:
Has a Patch: no Platform: All

Description

You can add additional columns of information in Tracker, and for image file types you can add things like the width and height. I've tried adding these as it makes my work a lot easier, but none of them are showing any information. They're all just dashes ( - ).

hrev44335 (gcc2h)

Attachments (6)

NoDimensions1.png (255.8 KB ) - added by jstressman 7 years ago.
no dimensions on any of the images in Tracker
ImageAttribsMissing1.png (134.1 KB ) - added by jstressman 7 years ago.
Thumbnailer modified.zip (159.7 KB ) - added by bbjimmy 7 years ago.
I changed the attribute names in libThumbnail.so to Media instead of GRAFX using DiskProbe.
Thumbnail130Haiku.x86.zip (454.0 KB ) - added by jstressman 6 years ago.
modified version of the full package
Thumbnail.hvif.zip (4.1 KB ) - added by jstressman 6 years ago.
just the new HVIF icon for Thumbnail
thumbnail2.png (19.5 KB ) - added by jstressman 6 years ago.
preview image of the new HVIF icon.

Download all attachments as: .zip

Change History (17)

by jstressman, 7 years ago

Attachment: NoDimensions1.png added

no dimensions on any of the images in Tracker

comment:1 by anevilyak, 7 years ago

Tracker just shows the attributes that are already there on disk, it doesn't know how to populate the data on its own. For this to work the information would need to be extracted and transferred to attributes. There are utilities on Bebits/Haikuware which do just that for audio files to extract ID3 tag data into BFS attributes, but I don't know if something similar exists for images or not.

comment:2 by jstressman, 7 years ago

http://haikuware.com/directory/view-details/multimedia/graphics/icon-tools/thumbnail

That claims to be able to write the necessary information, but even enabling the relevant options I still am not seeing the dimensions. :(

by jstressman, 7 years ago

Attachment: ImageAttribsMissing1.png added

comment:3 by jstressman, 7 years ago

And is it just me, or is it odd to have Tracker natively allow selecting to show information that Tracker cannot actually show without installing some third party application?

It seems to me that it shouldn't offer the option to do something it can't do unless that functionality is actually present. eg; don't show it unless the relevant add-ons are actually installed... or better yet don't show it unless the Tracker can automatically populate that information itself. Otherwise it's just poor design that confuses new users.

in reply to:  3 comment:4 by anevilyak, 7 years ago

Replying to jstressman:

And is it just me, or is it odd to have Tracker natively allow selecting to show information that Tracker cannot actually show without installing some third party application?

Tracker's role is simply a filesystem browser, it doesn't try to be everything-and-the-kitchen-sink. It gets the information about what attributes are potentially available for a file from the MIME database, and that's what it makes available as options. The assumption has always been that the apps writing the files will populate those attributes, assuming they even apply. Ideally it would be nice to possibly extend the mime sniffing mechanism to accept plugins to also extract information where possible but that's not easily possible with Tracker's current design (the code dates back to very early versions of BeOS and has quite a lot of cruft as a consequence).

in reply to:  2 comment:5 by humdinger, 7 years ago

Replying to jstressman:

http://haikuware.com/directory/view-details/multimedia/graphics/icon-tools/thumbnail

That claims to be able to write the necessary information, but even enabling the relevant options I still am not seeing the dimensions. :(

"Thumbnail" adds the attributes GRAFX:Height and GRAFX:Width while what you see in Tracker are the attributes of the supertype "image" Media:Width and Media:Height. Thumbnail's prefs allow to add their variation of attributes to the supertype, but I don't feel to sully my system now... :) Source is included and, should it compile, could be "ported" easily to Haiku.

by bbjimmy, 7 years ago

Attachment: Thumbnailer modified.zip added

I changed the attribute names in libThumbnail.so to Media instead of GRAFX using DiskProbe.

comment:6 by bbjimmy, 7 years ago

When Thumbnailer was made, there were no standard Height and Width attributes. The file I attatched changed the name of the attributes used by Thumbnailer to the standard Media:Height and Media:Width used bu HAIKU.

Version 1, edited 7 years ago by bbjimmy (previous) (next) (diff)

comment:7 by jstressman, 7 years ago

Thanks bbjimmy! Seems to work great here so far.

comment:8 by jstressman, 6 years ago

I've updated the original package to include this change for both the English and German versions, as well as for the included lib source. I've also updated the documentation to be html5 level (and improved readability a bit), and updated the images in that to reflect Haiku. Finally, I've added a new HVIF icon for Haiku to the package as well (and added it to the binaries).

by jstressman, 6 years ago

Attachment: Thumbnail130Haiku.x86.zip added

modified version of the full package

by jstressman, 6 years ago

Attachment: Thumbnail.hvif.zip added

just the new HVIF icon for Thumbnail

by jstressman, 6 years ago

Attachment: thumbnail2.png added

preview image of the new HVIF icon.

comment:9 by Janus, 4 years ago

MediaPlayer sets the media attributes for the opened files. The attributes are "Media:Length", "Audio:Bitrate", "Video:Bitrate". In the class MainWin.cpp there is this comment:

// Set some standard attributes of the currently played file.
// This should only be a temporary solution.

Should ShowImage do the same for the attributes width and height?

comment:10 by axeld, 4 years ago

I think the idea was to have some kind of a server that does this kind of stuff. Since we don't really have that (Clemens worked on an index_server once, but didn't really complete it), I'd be fine with having ShowImage do that for now.

comment:11 by Janus, 4 years ago

Resolution: fixed
Status: newclosed

Fixed in hrev49072.

Note: See TracTickets for help on using tickets.