Attachments (7)
Change History (22)
by , 12 years ago
| Attachment: | nfs_32x32.png added |
|---|
by , 12 years ago
| Attachment: | nfs_48x48.png added |
|---|
comment:1 by , 12 years ago
comment:2 by , 12 years ago
Somehow this is probably my fault. It should scale up the 32x32 version for you but perhaps it is rejecting the size before it gets to the scaling function. I know in some places we've allowed you to specify an icon size other than B_MINI_ICON and B_LARGE_ICON and in other places we restrict to just those sizes still.
comment:3 by , 12 years ago
| patch: | 0 → 1 |
|---|
by , 12 years ago
| Attachment: | 0001-Allow-Tracker-to-load-image-resources-with-any-size.patch added |
|---|
Allow Tracker to grab icons at any size, not just icon_size constants.
by , 12 years ago
| Attachment: | 0002-Surround-ConvertFromCMAP8-with-ifdef-__HAIKU__-gaurd.patch added |
|---|
Surround ConvertFromCMAP8 with #ifdef HAIKU gaurd again
comment:4 by , 12 years ago
I can't test these patches because I can't seem to get an NFS share to mount on my machine but I think this may solve the problem.
comment:5 by , 12 years ago
| Blocking: | 9588 added |
|---|
by , 11 years ago
by , 11 years ago
| Attachment: | Share Icon added |
|---|
by , 11 years ago
| Attachment: | Share Icon2 added |
|---|
comment:7 by , 11 years ago
Two HVIF icons were created in GCI for system shares. I'm not on Haiku right now, so can't tell if they are any good.
comment:8 by , 10 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
I can work on those HVIFs at some point later.
comment:9 by , 10 years ago
| patch: | 1 → 0 |
|---|
comment:10 by , 10 years ago
Nope, attached patch does not work. Tested against a NFS server I managed to get working (boy, that was a pain to set up...)
comment:11 by , 6 years ago
| Owner: | changed from to |
|---|
comment:12 by , 5 years ago
I got the fallback icon to load at >32px sizes but the testing was hard to do because there are very few bitmap icons left in Tracker. The only way I was able to test this change was to alter Tracker to use the old BeOS volume icon for my volume instead of the vector one. Before my patch we were returning an error if the size passed in was not 16 or 32 which is why the icon would show as blank for sizes larger than 32x32. However, we are able to scale 16px and 32px bitmaps to larger sizes and convert them to B_RGBA (instead of BeOS icon's CMAP8) color space using IconUtils. IconUtils does not do a straight conversion but instead uses a combination of scale2x, scale3x, scale4x, bilinear down-scaling and as a last resort bilinear up-scaling to achieve a nicer looking scaled icon. So while I got the bitmap icon scaling to work we should probably also have a fall back to our (bitmap) fall back to our (vector) fall back and choose some generic icon in the case that for some reason we were not able to provide a scaled version of the bitmap.
comment:13 by , 5 years ago
Implemented feature with fallback in https://review.haiku-os.org/c/haiku/+/1960
If for some reason the bitmap icon won't convert and scale we center the given icon bitmap in the bigger icon area.
comment:15 by , 5 years ago
| Milestone: | R1 → R1/beta2 |
|---|
Assign tickets with status=closed and resolution=fixed within the R1/beta2 development window to the R1/beta2 Milestone
Amazing that there are still some of them left. BTW this is probably not about scaling; I assume that Tracker will simply not know how to retrieve the resource in that size.