Opened 6 years ago

Last modified 3 months ago

#9554 assigned bug

[Tracker] doesn't scale built-in bitmap icons

Reported by: diver Owned by: jscipione
Priority: normal Milestone: R1
Component: Applications/Tracker Version: R1/Development
Keywords: Cc: diger
Blocked By: Blocking: #9588
Has a Patch: no Platform: All

Description

This is hrev45301.

Built-in tracker bitmap icons disappear if icon size > 32x32

Attachments (7)

nfs_32x32.png (9.0 KB) - added by diver 6 years ago.
nfs_48x48.png (12.8 KB) - added by diver 6 years ago.
0001-Allow-Tracker-to-load-image-resources-with-any-size.patch (1.3 KB) - added by jscipione 6 years ago.
Allow Tracker to grab icons at any size, not just icon_size constants.
0002-Surround-ConvertFromCMAP8-with-ifdef-__HAIKU__-gaurd.patch (823 bytes) - added by jscipione 6 years ago.
Surround ConvertFromCMAP8 with #ifdef HAIKU gaurd again
nfs.png (17.7 KB) - added by diger 6 years ago.
Share Icon (7.8 KB) - added by richienyhus 5 years ago.
Share Icon2 (7.8 KB) - added by richienyhus 5 years ago.

Download all attachments as: .zip

Change History (18)

Changed 6 years ago by diver

Attachment: nfs_32x32.png added

Changed 6 years ago by diver

Attachment: nfs_48x48.png added

comment:1 Changed 6 years ago by axeld

Amazing that there are still some of them left. BTW this is probably not about scaling; I assume that Tracker will simply not know how to retrieve the resource in that size.

comment:2 Changed 6 years ago by jscipione

Somehow this is probably my fault. It should scale up the 32x32 version for you but perhaps it is rejecting the size before it gets to the scaling function. I know in some places we've allowed you to specify an icon size other than B_MINI_ICON and B_LARGE_ICON and in other places we restrict to just those sizes still.

comment:3 Changed 6 years ago by jscipione

Has a Patch: set

Changed 6 years ago by jscipione

Allow Tracker to grab icons at any size, not just icon_size constants.

Changed 6 years ago by jscipione

Surround ConvertFromCMAP8 with #ifdef HAIKU gaurd again

comment:4 Changed 6 years ago by jscipione

I can't test these patches because I can't seem to get an NFS share to mount on my machine but I think this may solve the problem.

comment:5 Changed 6 years ago by richienyhus

Blocking: 9588 added

comment:6 Changed 6 years ago by diger

hrev46100 gcc4 - still no icon :(  

Last edited 6 years ago by diger (previous) (diff)

Changed 6 years ago by diger

Attachment: nfs.png added

Changed 5 years ago by richienyhus

Attachment: Share Icon added

Changed 5 years ago by richienyhus

Attachment: Share Icon2 added

comment:7 Changed 5 years ago by richienyhus

Two HVIF icons were created in GCI for system shares. I'm not on Haiku right now, so can't tell if they are any good.

comment:8 Changed 4 years ago by waddlesplash

Owner: changed from jscipione to waddlesplash
Status: newassigned

I can work on those HVIFs at some point later.

comment:9 Changed 4 years ago by waddlesplash

Has a Patch: unset

comment:10 Changed 4 years ago by waddlesplash

Nope, attached patch does not work. Tested against a NFS server I managed to get working (boy, that was a pain to set up...)

comment:11 Changed 3 months ago by waddlesplash

Owner: changed from waddlesplash to jscipione
Note: See TracTickets for help on using tickets.