Changes between Initial Version and Version 1 of Ticket #9586, comment 4


Ignore:
Timestamp:
Apr 22, 2014, 8:25:54 AM (10 years ago)
Author:
ttcoder

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #9586, comment 4

    initial v1  
    11You probably want to call `BView::MakeFocus()` on the webkit rendering BView. Even for keyboard events that don't involve the command key (down arrow, page down ..etc) it's good practice[*], and in the case of command-something it probably bypasses the BWindow code that is related to AddShortcut() and eats up "shortcuts". There's little to no downside to doing that, because even if the focus view does not know how to handle an event, that event will be forwarded up the BView hierarchy, something like the "Delegator(sp)" design pattern.
    22
    3 [*] And maybe it's related to a small bug I've noticed: page-down ..etc does not always work; e.g. if you do command-T to create a tab, then type an address or select a bookmark to load a page, that page won't be navigable... until you click inside it (BView::MouseDown() probably calls MakeFocus() I believe); I think keyboard events are even sent to the /previous/ tab, ie if I come back to the previously displayed tab I see it scrolled down..! Could file a ticket about that, but it sounds like it'd be a duplicate of this one.
     3[*] And maybe it's related to a small bug I've noticed: page-down ..etc does not always work; e.g. if you do command-T to create a tab, then type an address or select a bookmark to load a page, that page won't be navigable... until you click inside it (BView::MouseDown() probably calls MakeFocus() I believe); I think keyboard events are even sent to the /previous/ tab, ie if I come back to the previously displayed tab I see it scrolled down..! Could file a ticket about that, but it sounds like it'd be a duplicate of this one [in root cause, if not in symptoms].