Opened 4 years ago

Last modified 4 years ago

#16414 new bug

Possible BPath archiving regression

Reported by: ttcoder Owned by: nobody
Priority: normal Milestone: Unscheduled
Component: Kits/Storage Kit Version: R1/beta2
Keywords: Cc: ambroff
Blocked By: Blocking:
Platform: All

Description

Outbound drag'n'drop from one of my apps stopped working in beta2, since the "refs" field now holds an entry_ref with an empty "name" field (as confirmed by doing a PrintToStream() of the message). Turns out the app was building the dragged message in a kinda non-standard way, using AddFlat() instead of AddRef().

This is a simple fix, I now just use AddRef() instead. But I'm curious as to what happened.

Only change I found after a (very) quick glance is this one, but the change LGTM : https://git.haiku-os.org/haiku/commit/src/kits/storage?id=654135466f2ad0a080c41ddda423291a14e5fe61

Here's the fix in my code that makes it work again:

#if 0
			msg.AddFlat( "refs", item->Path() );
#else
			entry_ref ref;
			get_ref_for_path( item->Path()->Path(), &ref );
			msg.AddRef( "refs", &ref );
#endif
// followed by msg.PrintToStream(), view.DragMessage() etc

Change History (1)

comment:1 by waddlesplash, 4 years ago

Cc: ambroff added

It does look related. CCing ambroff.

Note: See TracTickets for help on using tickets.