Opened 4 years ago

Closed 2 years ago

#16512 closed bug (fixed)

virtio_block device ordering reversed

Reported by: kallisti5 Owned by: nobody
Priority: normal Milestone: R1/beta4
Component: System/Kernel Version: R1/beta2
Keywords: Cc:
Blocked By: Blocking:
Platform: All

Description

Just noticed this in qemu...

qemu-system-x86_64 -machine pc -chardev socket,id=console,path=/var/tmp/qemu-1354524-console.sock,server,nowait -serial chardev:console -nodefaults -m 4G -cpu max -netdev user,id=vnet,hostfwd=:127.0.0.1:0-:22 -device virtio-net-pci,netdev=vnet -smp 8 -enable-kvm -drive file=/tmp/haiku.img,if=none,id=drive0,cache=writeback -device virtio-blk,drive=drive0,bootindex=0 -drive file=/tmp/vm-test-i3tff3zn.tmp/data-fa2df.tar,if=none,id=data-fa2df,cache=writeback,format=raw -device virtio-blk,drive=data-fa2df,serial=data-fa2df,bootindex=1 -device VGA}}}

In the example above:
* -drive file=/tmp/haiku.img,if=none,id=drive0,cache=writeback
  * -device virtio-blk,drive=drive0,bootindex=0
* -drive file=/tmp/vm-test-i3tff3zn.tmp/data-fa2df.tar,if=none,id=data-fa2df,cache=writeback,format=raw
  * -device virtio-blk,drive=data-fa2df,serial=data-fa2df,bootindex=1 

These are positioned as:
* drive0 = haiku.img
* drive1 = data-fa2df.tar

However, after booting into qemu:
* Haiku is /dev/disk/virtual/virtio_block/1/raw
* tar is /dev/disk/virtual/virtio_block/0/raw

The attachment ordering is reversed (or random? Though the reverse seems consistent)

Change History (2)

comment:1 by korli, 2 years ago

Component: Drivers/Disk/VirtioSystem/Kernel
Milestone: UnscheduledR1/beta4

the ordering actually is from the device manager. https://review.haiku-os.org/c/haiku/+/5393

comment:2 by waddlesplash, 2 years ago

Resolution: fixed
Status: newclosed

Fix merged in hrev56206.

Note: See TracTickets for help on using tickets.