Bootmenu triggers reboot

[marcusoverhagen]

Entering the Haiku bootmenu triggers a reboot after leaving it. On my machine this has always been reproducible.

I've tracked down an access to a destroyed Partition object by the boot loader in src/system/boot/loader/loader.cpp

load_modules(stage2_args *args, Directory *volume) does

// iterate over the mounted volumes and load their file system
Partition *partition;
if (gRoot->GetPartitionFor(volume, &partition) == B_OK) {
   while (partition != NULL) {
      load_module(volume, partition->ModuleName());
      partition = partition->Parent();
   }
}

This partition pointer gets invalid and triggers a reboot, because Parent() does return an object that has been destroyed before the boot menu was shown. Thus the object has been overwritten by the boot menu code.

This can be seen in haikupartitions2.txt, the pointer is 0x0010971c

This problem doesn't seem to happen at all when not entering the bootmenu, see haikupartitions1.txt for reference.

[marcusoverhagen]

normal boot without bootmenu

[marcusoverhagen]

bootmenu and reboot

[axeld]

Thanks for investigating this, I'll have a look!

[axeld]

Does r23172 help for you? I have a similar problem on my laptop (only boots when the boot menu is not used), but it seems to be a different problem. This might be a duplicate of #690, though.

[marcusoverhagen]

Yes this fixes the problem.

However, I'm not sure if this code in partitions.cpp is save:

// move the partitions containing file systems to the partition
// list
fChildren.Remove(child);
gPartitions.Add(child);

[axeld]

Thanks for the update! The list iterator is safe to be used in this context, and the parent pointer is not affected by this code.

[axeld]

Confirmed to be a duplicate of #690.