Ticket #1735 (new enhancement)

Opened 9 months ago

Last modified 5 months ago

Integrate changes from the japanese community

Reported by: jackburton Owned by: axeld
Priority: normal Milestone: R1
Component: - General Version: R1 development
Cc: shinta Blocked By:
Platform: All Blocking:

Description

The Japanese community (the people at JPBE.net) made some changes to our libtextencoding.so to support their language more correctly. We asked them for the changes and we got them (already some time ago, actually). We should find a way to integrate the patches without breaking anything. I'm including here everything I got from Momoziro.

Attachments

unzpriv.h.patch (0.7 kB) - added by jackburton 9 months ago.
Patch for unzip
character_sets.cpp.patch (0.6 kB) - added by jackburton 9 months ago.
patch for libtextencoding

Change History

Changed 9 months ago by jackburton

Patch for unzip

Changed 9 months ago by jackburton

patch for libtextencoding

Changed 9 months ago by jackburton

Changed 9 months ago by jackburton

And here's the explanation from Momoziro:

The revision part of the unzip only erased "OEM_INTERN((string))" in "Ext_ASCII_TO_Native" macro of trunk/src/bin/unzip/unzpriv.h. The file name broke when the file name (Shift_JIS encoded multi-byte Japanese language characters) was mis-recognized to iso8859-1. I did the change that invalidate the character-code conversion. I think that this is not a good method.

Changed 5 months ago by shinta

  • cc shinta added
Note: See TracTickets for help on using tickets.