[Trac] Include attachment indicator in email notifications

[umccullough]

Currently there there appears to be no email indicator when an attachment is added to a ticket. This causes some people to miss when an attachment is added to a ticket unless a comment stating such is also added.

Would be nice if attachments and their names are also mentioned in the email notifications.

[nielx]

Looking into this ...

[nielx]

Okay, found something.

 http://trac.edgewall.org/ticket/2259

There is a patch attached, which I will commit to our locally modified Trac 0.11. Marking it as fixed, since this will be included when Trac 0.11 goes live.

[umccullough]

Nice!

Maybe the reason nobody has committed it to Trac yet is because they didn't notice a patch has been attached to that ticket ;)

[nielx]

Well, the official explanation is that it is not generic enough. Anyway, worksforme now :-)

[umccullough]

From your comment, and a quick test, this means the current Trac wasn't patched - and that you're maintaining a newer (not-yet-implemented) Trac 0.11 update where you've applied the patch already?

[nielx]

Yes. There is one crucial bug in trac 0.11beta which is preventing me from using it. But it is indeed fixed in a local repository.

[umccullough]

Another test to ensure that it's fixed (since I was never able to test before)

[umccullough]

Reopening as this is apparently not fixed in the new Trac 0.11RC1 now.

(Preferably fixed issues for website/trac don't get closed until they're actually available to the reporter)

[nielx]

I thought I had this one nailed. Probably one of the code merges of newer Trac installations broke it. I will look into this on Thursday.

[nielx]

Reassign to generic owner.

[umccullough]

As mentioned in the edgewall ticket above, there's another solution:

 http://trac-hacks.org/wiki/AnnouncerPlugin

Can we test this out?

[pulkomandy]

The rss feed can be used for that. I tend to use it more than mail notifications, actually.

[nielx]

Replying to umccullough:

As mentioned in the edgewall ticket above, there's another solution:  http://trac-hacks.org/wiki/AnnouncerPlugin Can we test this out?

I am a bit cautious when it comes to modules that replace a major internal subsystem of Trac. At this point in time, I think it is reasonably safe to say that the next major version of Trac (0.12) will not fix this, but since this release should be sooner rather than later, I actually prefer to wait until the module is ported to Trac 0.12 to test it out.

[nielx]

Taking another stab at this one, as it seems it will not be in Trac 0.12.

[nielx]

Implementation finished and tested on a local installation. See  http://hg.haiku-os.org/trac-attachmentnotifier/

I am hoping to roll this change out soon.

[nielx]

Test attachment

[nielx]

Deployed (and tested) as of now. Please create a new bug report if you find any issues.