Ticket #2201 (closed bug: fixed)

Opened 2 weeks ago

Last modified 6 days ago

[PATCH] Disc Time Label (fDiscTime) not long enough

Reported by: sbrokenshire Assigned to: darkwyrm
Priority: normal Milestone: R1
Component: Applications/CDPlayer Version: R1 development
Cc: Platform: All

Description

Using VMWare, Haiku SVN r25302

This is reproduced by starting CDPlayer, inserting an Audio CD (over 10 minutes long) and playing it.

Disc Time Label (fDiscTime) shows the current and total disc time but total disc time is partially shown because fDiscTime is not long enough. Expected both current and total disc time to be shown in full.

Patch attached.

Attachments

CDPlayer.fDiscTimenotlongenough.diff (480 bytes) - added by sbrokenshire on 05/03/08 14:56:52.
Patch for fDiscTime in CDPlayer

Change History

05/03/08 14:56:52 changed by sbrokenshire

  • attachment CDPlayer.fDiscTimenotlongenough.diff added.

Patch for fDiscTime in CDPlayer

05/10/08 06:29:58 changed by stippi

  • status changed from new to closed.
  • resolution set to fixed.

Fixed in r25412. I did not use your patch, because it was just another way of hardcoding the size, and it also didn't fix the potential track time truncation either. The problem was that the size calculation was based on the wrong string with regards to proportional fonts.