Ticket #2210 (closed enhancement: fixed)

Opened 1 week ago

Last modified 2 days ago

[PATCH] Followup of ticket 2170 : Revert button now works for timezones too

Reported by: stpere Assigned to: stippi
Priority: normal Milestone: R1
Component: Preferences/Time & Date Version: R1 development
Cc: Platform: All

Description

This enhancement is a followup of ticket 2170 :

Following suggestion from Stephan, I've enhanced the revert feature of the Time preflets.

1. Clicking the revert button now also revert the timezone.
2. I have moved the revert button to the BaseView (below the tabs)
3. Since that on the default vmware-image (at least on my setup), there are no timezone link and this seems to confuse the preflet (it shows no text in the rolldown menu and the city list is empty), now, it assumes the Greenwich meridian time and shows it in the "Others" area.

Note: I've encountered a crash once when reverting, but have not been capable to reproduce it. I've tried all the combinations I could think of (default to random timezone, then revert; random timezone to random timezone, then revert; etc...) and it seems to work ok.

Note 2: I'm a bit confused by the desired behaviour or the localtime/gmt radio button in datetime panel. Could someone confirms it's ok?

Attachments

RevertTimezone.diff (12.8 kB) - added by stpere on 05/04/08 15:54:14.
Add revert feature for the timezones in Time Preflet (with bugfix)

Change History

05/04/08 15:54:14 changed by stpere

  • attachment RevertTimezone.diff added.

Add revert feature for the timezones in Time Preflet (with bugfix)

05/10/08 06:43:54 changed by stippi

  • owner changed from axeld to stippi.
  • status changed from new to assigned.

Working on it.

05/10/08 07:25:15 changed by stippi

  • status changed from assigned to closed.
  • resolution set to fixed.

Applied in r25415. Nice work, thanks a lot and sorry for the delay!