Ticket #2218 (closed enhancement: fixed)

Opened 6 days ago

Last modified 6 days ago

Key binding for turning on/off inputh methods (IM)

Reported by: shinta Assigned to: korli
Priority: normal Milestone: R1
Component: Servers/input_server Version: R1 development
Cc: koki Platform: x86

Description

Currently, key binding for turning on/off input methods (switching Roman <--> (Japanese) input methods) is "Alt+Space" or "Alt+Zenkaku/Hankaku". (FYI: Zenkaku/Hankaku is a key which Japanese keyboard has.)

Alt+Space is good.

Alt+Zenkaku/Hankaku is required to change in Japanese community. Please no-midifiers Zenkaku/Hankaku, not Alt+Zenkaku/Hankaku. Currently, Zenkaku/Hankaku itself has no function, so, it is reasonable to make no-modifiers Zenkaku/Hankaku turn on/off.

Actually, old versions of Windows used Alt+Zenkaku/Hankaku to turn on/off input methods, but, current version of Windows uses no-modifiers Zenkaku/Hankaku.

cf: JPBE.net IM relative forum thread
http://www.jpbe.net/forum/viewtopic.php?p=7763#7763

Haiku: r25124+
SHINTA (enhancement No.2)

Attachments

InputServer.diff (0.7 kB) - added by shinta on 05/10/08 07:04:04.

Change History

05/10/08 01:44:50 changed by koki

  • cc set to koki.

SHINTA-san,

Can you provide a patch to attain the desired change? If you can, please provide one as an attachment.

05/10/08 01:53:57 changed by shinta

I'll try.

05/10/08 07:04:04 changed by shinta

  • attachment InputServer.diff added.

05/10/08 07:09:03 changed by shinta

This patch and patch for #2222 (r25413) realize this enhancement.

05/10/08 07:40:20 changed by korli

I applied in r25416. Could you confirm please ?

05/10/08 08:24:14 changed by shinta

Thank you.

But, a bit difference.

not 

if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0
&& (byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU)) {

but 

if ((fKeyInfo.modifiers & B_COMMAND_KEY) != 0
&& byte == ' ' || static_cast<uint8>(byte) == B_ZENKAKU_HANKAKU) {

because B_ZENKAKU_HANKAKU doesn't need B_COMMAND_KEY.

05/10/08 08:54:19 changed by korli

  • status changed from new to closed.
  • resolution set to fixed.

Applied in r25421. It's better to explicitly use parenthesis for such comparisons :)

05/10/08 09:33:27 changed by shinta

Thank you :)