BDirectory::Contains() is broken for certain cases of similar paths

[anevilyak]

Steps to reproduce:

1. Create a directory called New Folder.
2. Create a directory called New Folder 2.
3. Get a BDirectory object for New Folder, a BEntry for New Folder 2, and call BDirectory::Contains() on the resulting entry. It will (incorrectly) return true, because Contains currently compares the paths of the two up to the length of the directory itself. Attached please find a patch intended to fix the situation by comparing the path components individually.

[anevilyak]

On second thought, that patch is flawed also, give me some time to rework.

[anevilyak]

Proposed fix for Contains() issues.

[anevilyak]

Updated patch attached, let me know if you see any problems with it, or perhaps a better way to accomplish it, otherwise I can commit that.

[axeld]

Isn't that a bit too complicated? I think all that's missing is a check if the other path actually ends at that point, ie. has a '/' at that position or not.

[anevilyak]

Indeed, you're right, thanks for reviewing! Sometimes it's easy to miss the obvious :) Fixed in r28754.