Opened 15 years ago

Closed 12 years ago

#4125 closed bug (fixed)

NULL device is translated to '//'

Reported by: brecht Owned by: bonefish
Priority: normal Milestone: R1
Component: File Systems/UserlandFS Version: R1/pre-alpha1
Keywords: gsoc2012 Cc:
Blocked By: Blocking:
Platform: All

Description

UserlandFS passes '' as the device to the FS when no device has been specified when mounting it.

source:haiku/trunk/src/add-ons/kernel/file_systems/userlandfs/server/UserlandRequestHandler.cpp@29872#L233

Attachments (2)

4125.patch​ (988 bytes ) - added by pdziepak 12 years ago.
0001-Fix-4125-NULL-device-is-translated-to.patch​ (1.6 KB ) - added by pdziepak 12 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by brecht, 15 years ago

Component: File Systems → File Systems/UserlandFS
Owner: changed from axeld to bonefish
Summary: [userlandfs] NULL device is translated to '//' → NULL device is translated to '//'

by pdziepak, 12 years ago

Attachment: 4125.patch​ added

comment:2 by pdziepak, 12 years ago

patch: 0 → 1

comment:3 by pdziepak, 12 years ago

Keywords: gsoc2012 added

The problem appeared to be on the request creating side (i.e. in the kernel add-on) which did not support NULL pointers properly.

Relocation of addresses in request when it is received translates offset = 0, size = 0 to pointer NULL so that no change in that part of code was required.

comment:4 by bonefish, 12 years ago

The patch looks good. Please provide it in git format-patch format. The null pointer check should be data != NULL though.

by pdziepak, 12 years ago

Attachment: 0001-Fix-4125-NULL-device-is-translated-to.patch​ added

comment:5 by bonefish, 12 years ago

Resolution: → fixed
Status: new → closed

Thanks, applied in hrev43968.

Note: See TracTickets for help on using tickets.