Make copyright notice localization-friendly

[koki]

The license notice under the Copyright section of the AboutThisSystem application is split into two localization strings, making it hard (and probably impossible in some cases) to translate it properly into other languages.

The full notice is displayed as follows (without quotes):

"The code that is unique to Haiku, especially the kernel and all code that applications may link against, is distributed under the terms of the MIT license. Some system libraries contain third party code distributed under the LGPL license. You can find the copyrights to third party code below."

The above notice is split into the two following localization strings:

"The code that is unique to Haiku, especially the kernel and all code that applications may link against, is distributed under the terms of the"

...and...

". Some system libraries contain third party code distributed under the LGPL license. You can find the copyrights to third party code below."

The desired localization-friendly format would be one that consolidates the notice into one translation string, such as (without quotes)...

"The code that is unique to Haiku, especially the kernel and all code that applications may link against, is distributed under the terms of the %s license. Some system libraries contain third party code distributed under the LGPL license. You can find the copyrights to third party code below."

...where %s could be used as a variable for the license name (only if needed).

[pulkomandy]

This is because we are inserting an hyperlink on "MIT Licence". The API thus needs the insertions to be done in 3 pieces (before, inside, and after the hyperlink). I don't see a good way to fix that without a redesign of the API of this view...

[koki]

Replying to pulkomandy:

This is because we are inserting an hyperlink on "MIT Licence". The API thus needs the insertions to be done in 3 pieces (before, inside, and after the hyperlink). I don't see a good way to fix that without a redesign of the API of this view...

After reading your explanation, I checked on HTA and it looks like there are keys for each of the three pieces that form this paragraph (IOW, the license string is not hardcoded as I had wrongly assumed). If that is the case (can you please confirm?), then there should be no problem from a translation POV, and it would be OK to close this ticket as invalid.

[pulkomandy]

Yes, that's it, the 3 parts are translatable separately. Of course one single string would be better, but I don't know how to do that without losing the hyperlink...

Closing as invalid for now then.