[Tracker] don't try to fix executable bit on read only file systems

[diver]

Some files (e.g. images) from my ext3 have executable bit set. Trying to open such files results in a tracker message:


If I try to fix it tracker shows:


The only way I could open such files is to use Open with menu.
I think that offering to fix executable bit on read only partitions doesn't make any sense.

[diver]

This is also the case for vboxsf file system.

[diver]

Probably there should be a check for volume.IsReadOnly() in ​TrackerLaunchDocuments() in FSUtils.cpp.

[diver]

diff --git a/src/kits/tracker/FSUtils.cpp b/src/kits/tracker/FSUtils.cpp
index 8a75bbc..152731f 100644
--- a/src/kits/tracker/FSUtils.cpp
+++ b/src/kits/tracker/FSUtils.cpp
@@ -3469,7 +3469,8 @@ _TrackerLaunchDocuments(const entry_ref* /*doNotUse*/, const BMessage* refs,
                                "The file is mistakenly marked as executable. "));
                        alertString.ReplaceFirst("%name", app.name);
 
-                       if (!openWithOK) {
+                       BVolume volume(documentRef.device);
+                       if (!openWithOK && !volume.IsReadOnly()) {
                                // offer the possibility to change the permissions
 
                                alertString << B_TRANSLATE("\nShould this be fixed?");

With the above change ​launching a file fails with "The file is mistakenly marked as executable." error.

[jessicah]

I think the better fix in the case of a read-only file-system would be to set some sort of flag to ignore the executable bit to emulate what happens when ​retrying after successfully unsetting the executable bit on a writeable file-system.

[diver]

Still here in hrev53129.

[korli]

​https://review.haiku-os.org/c/haiku/+/5425

[waddlesplash]

Merged in hrev56235