PackageInstaller crashes after installing package

[richienyhus]

While installing Globe Webeditor, PackageInstaller crashes.

​http://www.haikuware.com/directory/view-details/development/editors/globe-webeditor

[sil2100]

I can't seem to reproduce your problem, the package globe_v040.pkg installs without any problems here. When does the PackageInstaller crash in your case? Does it start the installation? If it does, on what file number or installation stage does it crash? Do you run it on a virtual machine or a real computer?

Such information would be most helpful. Thanks.

[richienyhus]

It crashed on the "package has been installed" screen.

And this was on a real system (AMD Sempron, KM51G-754).

[richienyhus]

I think this can be closed. I've tried again and it installs just fine.

It seemed to crash just as the installtion finished, while also webpositive froze Tracker around about the same time

[stippi]

A bug is a bug and doesn't go away when one just closes a ticket. :-) We just need to get to the bottom of it. WebPositive cannot freeze anything, though.

[sil2100]

Indeed, this still is a bug. From what I see in the debug output the problem is in the Stop() method - and there indeed is one error in my code there that might possibly make the application crash. The fCurrentScript variable is used in the Stop() code for instance, but it is not initialized to NULL at object construction, so logically, it should crash more often in normal packages (packages with no script files). I'm surprised that I can't reproduce this problem when it's so obvious.

Whether or not it's actually the problem here, I'm attaching the diff since it is a bug anyway.

[sil2100]

fCurrentScript fix

[mmlr]

To reproduce such problems more reliably, make use of libroot_debug that includes the debug heap. It will initialize memory to 0xcc and therefore expose problems like these. To run an app with it you can use LD_PRELOAD=libroot_debug.so TheAppInQuestion from the command line.

[stippi]

Probably fixed in hrev36940. Thanks!