Opened 13 years ago
Closed 13 years ago
#7548 closed bug (fixed)
Patch to make vertical BSliders work
| Reported by: | Pete | Owned by: | stippi |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Kits/Interface Kit | Version: | R1/alpha2 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Platform: | All |
Description
I guess I'm the first person to have actually needed vertical sliders, but found that they worked very badly in my ported BeOS app. (I see Stippi noted this three years ago, but apparently got sidetracked...)
The attached patch fixes the observed problems:
Height of sliders was never more than 100 pixels
Slider bar fill colouring didn't work
The triangle thumb (in ControlLook) wasn't rotated
(I notice that Haiku triangle thumbs are on the right, while BeOS had them on the left. I vaguely find the Haiku convention more natural, so I didn't mess with that.)
Attachments (1)
Change History (5)
by , 13 years ago
| Attachment: | vslider.diff added |
|---|
comment:1 by , 13 years ago
| patch: | 0 → 1 |
|---|
comment:2 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → in-progress |
Patch looks fine, thank you!
comment:3 by , 13 years ago
Applied with coding style corrections in hrev41881 (you probably get merge conflicts when you update, please have a look at what I changed). Thanks for your work, greatly appreciated!
comment:4 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | in-progress → closed |
Patch for Slider.cpp and ControlLook.cpp