Software renderer should gracefully handle unsupported color spaces.

[xray7224]

Currently, if one attempts to instantiate the mesa software renderer (legacy or new) in an unsupported color space (i.e. if the desktop is set to 8-bit color), the app will crash into the debugger. This should be handled a bit more gracefully. Simply removing the debugger() call doesn't appear to suffice though, since the return from _SetupRenderBuffer() is ignored, causing issues elsewhere later.

[anevilyak]

Are you running in 8-bit color mode? If so, that's not currently supported.

[xray7224]

I was yes, sorry. I don't know why it defaults to that. It works fine now i've switched it to 32 bit mode.

[anevilyak]

No problem, it should fail gracefully in that case instead of simply hitting the debugger though.

[kallisti5]

Yeah, I agree... I think it does try to return gracefully though on 8-bit color: ​http://cgit.haiku-os.org/haiku/tree/src/add-ons/opengl/swrast/MesaSoftwareRenderer.cpp#n608

We try to handle _SetupRenderBuffer failures gracefully here: ​http://cgit.haiku-os.org/haiku/tree/src/add-ons/opengl/swrast/MesaSoftwareRenderer.cpp#n599

However here, not so much... ​http://cgit.haiku-os.org/haiku/tree/src/add-ons/opengl/swrast/MesaSoftwareRenderer.cpp#n235

I probably should check color spaces much earlier on in the renderer. Any changes made to swrast need to made identically as possible in swrast_legacy.

I'll take a crack at it :)

[kallisti5]

hmm.. actually we do try to bail on incorrect colorspace here: ​http://cgit.haiku-os.org/haiku/tree/src/add-ons/opengl/swrast/MesaSoftwareRenderer.cpp#n151

either way, I'll fix it. Probably something getting dereferenced or something.

[cocobean]

Resolved. Tested with hrev55507 x86_64.

[pulkomandy]

Yes, this should be fixed by the latest Mesa update.