#8881 closed enhancement (fixed)
[Backgrounds] add support for color drops
| Reported by: | diver | Owned by: | korli |
|---|---|---|---|
| Priority: | normal | Milestone: | R1 |
| Component: | Preferences/Backgrounds | Version: | R1/Development |
| Keywords: | gci2014 | Cc: | |
| Blocked By: | Blocking: | ||
| Platform: | All |
Description (last modified by )
The Backgrounds preferences should accept color drops (from Colors! or other similar apps) just like the desktop background itself does.
Attachments (2)
Change History (12)
comment:2 by , 10 years ago
| Description: | modified (diff) |
|---|
Added a description to the ticket so it is more clear :)
by , 10 years ago
| Attachment: | 0001-Fix-8881-Add-color-drops-to-Backgrounds.patch added |
|---|
comment:4 by , 10 years ago
| patch: | 0 → 1 |
|---|
follow-up: 6 comment:5 by , 10 years ago
I think that BackgroundsApplication::MessageReceived() should only forward the dropped message if it contains a "RGBColor" data of type B_RGB_COLOR_TYPE. One could drop something else and be handled later in the method.
comment:6 by , 10 years ago
Replying to korli:
I think that BackgroundsApplication::MessageReceived() should only forward the dropped message if it contains a "RGBColor" data of type B_RGB_COLOR_TYPE. One could drop something else and be handled later in the method.
You are right.
comment:7 by , 10 years ago
| patch: | 1 → 0 |
|---|
by , 10 years ago
| Attachment: | 0001-Fix-8881-Add-color-drops-to-Backgrounds.2.patch added |
|---|
comment:8 by , 10 years ago
| patch: | 0 → 1 |
|---|
comment:9 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Patch applied in rev48589. Thanks!
comment:10 by , 10 years ago
| Keywords: | gci2014 added |
|---|
Note:
See TracTickets
for help on using tickets.
If I correctly understand, currently color drops works fine on Haiku: eg If I drop a color from the application "Colors!" to the Desktop, this will change the background color. However if i do this operation while the Background preflet is open, the preview isn't updated.
Ok: I have confused "background" with "Backgrounds" (the app), sorry for the noise :-)