[Deskbar] icons are broken for supertypes

[diver]

comman line app have broken icons in Deskbar. To reproduce, launch top from tracker.

[johndrinkwater]

Doesn't affect just CLI applications; anything without a custom icon that relies on the parent type's icon has this issue (like Playground)

[jackburton]

I think I found the problem. TBarApp::AddTeam() uses BBitmap::SetBits() and passes B_RGB32 as colorspace parameter, but SetBits() interprets that as B_RGB24_BIG (to mimic R5's behaviour, AFAIK). Passing B_RGBA32 instead should be fine.

[jackburton]

Replying to jackburton:

I think I found the problem. TBarApp::AddTeam() uses BBitmap::SetBits() and passes B_RGB32 as colorspace parameter, but SetBits() interprets that as B_RGB24_BIG (to mimic R5's behaviour, AFAIK). Passing B_RGBA32 instead should be fine.

Actually it already passes RGBA32. looks like the problem was elsewhere. Should be fixed in rev 19420, please review.

[axeld]

Stefano, in case you missed it: please always write r19420, so Trac can pick it up and create a link to the revision.

[jackburton]

Replying to axeld:

Stefano, in case you missed it: please always write r19420, so Trac can pick it up and create a link to the revision.

Yes, sorry, I forgot about that. What about the change ? Does it look correct ? At least I can't reproduce this bug anymore.

[jackburton]

Also, the generic application icon in deskbar is still the old style 8 bit icon (and that's why my change fixed the problem)

[jackburton]

Original bug is fixed, I'll open a new bug for the 8 bit icon problem