Ticket #12334: 0001-Added-error-messages-when-converted-file-cannot-be-w.patch

src/apps/mediaconverter/MediaConverterApp.cpp

@@ -204 +204 @@
 
     name.Append(outputFormat->file_extension);
 
+    BEntry directoryEntry;
+    directory.GetEntry(&directoryEntry);
+    if (!directoryEntry.Exists()) {
+        BAlert* alert = new BAlert(B_TRANSLATE("Error"),
+            B_TRANSLATE("Selected directory not found. "
+                "Defaulting to /boot/home"),
+            B_TRANSLATE("OK"));
+        alert->SetFlags(alert->Flags() | B_CLOSE_ON_ESCAPE);
+        alert->Go();
+        directory.SetTo("/boot/home");
+    }
+
     BEntry inEntry(ref);
     BEntry outEntry;
 
@@ -318 +330 @@
 
 
             } else {
+                srcIndex++;
+                BString error(
+                    B_TRANSLATE("Error converting '%filename'"));
+                error.ReplaceAll("%filename", inRef.name);
+                fWin->SetStatusMessage(error.String());
                 fWin->Unlock();
                 break;
             }
@@ -391 +408 @@
                         B_TRANSLATE("Audio quality not supported"));
                     fWin->Unlock();
                 }
+            } else {
+                fWin->SetStatusMessage(
+                    B_TRANSLATE("Error creating track."));
             }
 
         } else if (inFormat.IsVideo() && (videoCodec != NULL)) {
@@ -465 +485 @@
                     fWin->SetVideoQualityLabel(videoQualitySupport);
                     fWin->Unlock();
                 }
+            } else {
+                fWin->SetStatusMessage(
+                    B_TRANSLATE("Error creating video."));
             }
         } else {
             //  didn't do anything with the track
+            fWin->SetStatusMessage(
+                B_TRANSLATE("Input file not recognized as Audio or Video"));
             inFile->ReleaseTrack(inTrack);
         }
     }

src/apps/mediaconverter/MediaConverterWindow.cpp

@@ -9 +9 @@
 
 #include <stdio.h>
 #include <string.h>
+#include <unistd.h>
 
 #include <Alert.h>
 #include <Application.h>
@@ -1005 +1006 @@
 void
 MediaConverterWindow::_SetOutputFolder(BEntry entry)
 {
-    fOutputDir.SetTo(&entry);
+    BPath path;
+    entry.GetPath(&path);
+    if (access(path.Path(), W_OK) != -1) {
+        fOutputDir.SetTo(&entry);
+    } else {
+        BString errorString(B_TRANSLATE("Error writing to location: %strPath%."
+            " Defaulting to location: /boot/home"));
+        errorString.ReplaceFirst("%strPath%", path.Path());
+        BAlert* alert = new BAlert(B_TRANSLATE("Error"),
+            errorString.String(), B_TRANSLATE("OK"));
+        alert->SetFlags(alert->Flags() | B_CLOSE_ON_ESCAPE);
+        alert->Go();
+        fOutputDir.SetTo("/boot/home");
+    }
     TruncateOutputFolderPath();
 }